Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] genirq: implement read_irq_line for interrupt lines
Date: Sat, 16 Apr 2011 00:39:47 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1104160030480.2744@localhost6.localdomain6> (raw)
In-Reply-To: <4DA8C1E2.3020205@codeaurora.org>

On Fri, 15 Apr 2011, Abhijeet Dharmapurikar wrote:

> Thomas Gleixner wrote:
> > On Fri, 15 Apr 2011, Abhijeet Dharmapurikar wrote:
> > 
> > > Some drivers need to know what the status of the interrupt line is.
> > > This is especially true for drivers that register a handler with
> > > IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING and in the handler they
> > > need to know which edge transition it was invoked for.
> > 
> > What's the purpose of this? How is that going to be used?
> 
> The main purpose is to know in the handler if it was invoked becuase of a
> rising edge or the falling edge.

Come on. That's not an explanation. I know that already and it does
not answer my question how this is going to be used. IOW: What does
the driver do aside of knowing that it was a rising falling edge?
 
> Now one could say that the driver should maintain some state and toggle it
> upon each invocation of this handler. That scheme quickly goes out of sync
> because we might ignore interrupts while suspended.

Suspend is a totaly different issue. I have the impression that you
are trying to solve some basic issue at the driver level again - just
this time you add some core helper to get it solved.

Can you please show _AND_ explain the code which is going to use this?

Thanks,

	tglx

  reply	other threads:[~2011-04-15 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 18:42 [RFC PATCH] genirq: implement read_irq_line for interrupt lines Abhijeet Dharmapurikar
2011-04-15 19:03 ` Mathieu Desnoyers
2011-04-15 22:02   ` Abhijeet Dharmapurikar
2011-04-15 19:11 ` Thomas Gleixner
2011-04-15 22:08   ` Abhijeet Dharmapurikar
2011-04-15 22:39     ` Thomas Gleixner [this message]
2011-04-15 23:06       ` Abhijeet Dharmapurikar
2011-04-15 19:17 ` David Daney
2011-04-15 22:17   ` Abhijeet Dharmapurikar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1104160030480.2744@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox