[PATCH 05/10] clk: Add support for simple dividers

Sascha Hauer
2011-04-20T06:36:43Z

On Tue, Apr 19, 2011 at 03:28:50PM -0700, Saravana Kannan wrote:
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> >> >>
> >> >> We should really have something like:
> >> >> clk_set_rate_range(min, ideal, max)
> >> > (Note this is orthogonal to the question if set_rate may barf on
> >values
> >> > other than the return values of round_rate.)
> >> >
> >> > clk_set_rate_range can even be implemented with clk_round_rate that
> >is
> >> > just required to fulfill:
> >>
> >> I think it's more important that we try to find a new API that's
> >better
> >> than clk_round_rate(). We can worry about the specifics of the
> >> implementation later.
> >
> >You found it and Uwe found a way to implement this ontop of the old
> >API,
> >that's a comfortable situation, isn't it?
>
> Well, do we all agree to this new API? I have no problem with Uwe's
> helper fn or his suggestion, if we all agree on the final API. I just
> didn't want him wasting his time when the API is not finalized.

As Uwes suggestion does not change the internal clock API it's
relatively simple to try out. With this we moved to the
add-a-helper-function class of patches and are not in the
change-internal-and-external-API-with-hundreds-of-users
class anymore.

Sascha

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |