public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: AT91: Convert to fasteoi IRQ handler, and remove ARM irq_finish
Date: Thu, 28 Apr 2011 21:48:52 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1104282148070.3005@ionos> (raw)
In-Reply-To: <20110428192403.GA21061@linutronix.de>

On Thu, 28 Apr 2011, Sebastian Andrzej Siewior wrote:

> * Andrew Victor | 2011-04-28 19:12:23 [+0200]:
> 
> >hi,
> >
> >>> - ? ? desc->irq_data.chip->irq_unmask(&desc->irq_data);
> >>> - ? ? /* now it may re-trigger */
> >>> + ? ? /* acknowledge interrupt - now it may re-trigger */
> >>> + ? ? desc->irq_data.chip->irq_eoi(&desc->irq_data);
> >>> ?}
> >>
> >> why does this handler mess with the parent irq chip ?
> >> this looks pretty wrong to me.
> >
> >This is a chained-handler, and without that line the end-of-interrupt
> >doesn't seem to be signalled.
> 
> Most chain handler don't mess with other irq chips. Why is the parent
> irq hanlder set level and not eoi? Wouldn't this make this superflous?
> 
> btw: tglx removed direct desc access so this patch won't apply.

It does, you still can access irq_data, but you should use the
wrappers.

Thanks,

	tglx

  reply	other threads:[~2011-04-28 19:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 13:09 AT91: Convert to fasteoi IRQ handler, and remove ARM irq_finish Andrew Victor
2011-04-28  9:33 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 15:18 ` torbenh
2011-04-28 17:12   ` Andrew Victor
2011-04-28 19:24     ` Sebastian Andrzej Siewior
2011-04-28 19:48       ` Thomas Gleixner [this message]
2011-04-28 20:20         ` Sebastian Andrzej Siewior
2011-04-28 20:03       ` Andrew Victor
2011-04-29  8:22         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1104282148070.3005@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox