From mboxrd@z Thu Jan 1 00:00:00 1970 From: tglx@linutronix.de (Thomas Gleixner) Date: Mon, 16 May 2011 16:44:06 +0200 (CEST) Subject: [PATCH] ARM: twd: Adjust localtimer frequency withcpufreqnotifiers In-Reply-To: <4DD10814.1010103@ti.com> References: <1290060899-9786-1-git-send-email-ccross@android.com> <4D70BE9D.4000507@stericsson.com> <4D714C17.7080102@gmail.com> <7e9fafa016bfe536ccc373fc2cc7ba61@mail.gmail.com> <4DD10814.1010103@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 16 May 2011, Santosh Shilimkar wrote: > On 5/14/2011 9:21 PM, Thomas Gleixner wrote: > Just for my understanding, the clockevents_reconfigure() needs to > be called with interrupts disabled on that CPU as part of > the CPUFREQ notifiers. I assume the right place is do it > in POST notifier after the CPU clock and hence TWD clock is > updated. Is that right ? Yes. > Since there is need to call this API in interrupt > disable context, does it make sense to take care of it > inside the API itself instead of relying on caller fn ? Hmm, no strong opinion > The arch's where the per CPU TWD's share clock, per-cpu > clock-events should be reconfigured on all CPUs, whenever > the parent(CPU) clock has changed using some thing like > smp_call_function_any() etc. Is that right understanding? Yes. If that's a common requirement we should move that to core code. Thanks, tglx