From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Use arch_spin_lock for unwind to avoid lockdep deadlock
Date: Tue, 17 May 2011 21:31:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1105172115560.3078@ionos> (raw)
In-Reply-To: <alpine.LFD.2.02.1105171737260.3078@ionos>
On Tue, 17 May 2011, Thomas Gleixner wrote:
> On Tue, 17 May 2011, Peter Zijlstra wrote:
>
> > On Tue, 2011-05-17 at 16:11 +0200, Thomas Gleixner wrote:
> > > When lockdep traces a lock taken in a module the arm unwinder takes
> > > unwind_lock which causes a recursive lockdep call deadlocking itself
> > > on the unwind_lock.
> > >
> > > Make unwind_lock an arch_spin_lock to avoid the lockdep call and use
> > > the raw_local_irq_save/restore() variants to avoid irq tracing as
> > > well.
> >
> > That doesn't parse, lockdep has recursion protection, this shouldn't
> > happen.
>
> Gah, misread the splat. The problem is
>
> unwind() -> lock() -> lock_acquired() -> unwind() -> lock()
Grmpf, no. That does not make sense as the stack trace is taken in
lock_aquire() which happens before lock(). Ignore that for now until I
have it reproduced.
Thanks,
tglx
next prev parent reply other threads:[~2011-05-17 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 14:11 [PATCH] arm: Use arch_spin_lock for unwind to avoid lockdep deadlock Thomas Gleixner
2011-05-17 14:20 ` Peter Zijlstra
2011-05-17 15:45 ` Thomas Gleixner
2011-05-17 19:31 ` Thomas Gleixner [this message]
2011-05-17 15:26 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1105172115560.3078@ionos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox