From mboxrd@z Thu Jan 1 00:00:00 1970 From: tglx@linutronix.de (Thomas Gleixner) Date: Tue, 31 May 2011 12:38:40 +0200 (CEST) Subject: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support In-Reply-To: <1306830661-9546-1-git-send-email-mattias.wallin@stericsson.com> References: <1306830661-9546-1-git-send-email-mattias.wallin@stericsson.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 31 May 2011, Mattias Wallin wrote: > +static cycle_t clksrc_db8500_prcmu_read(struct clocksource *cs) > +{ > + u32 count, count2; > + > + do { > + count = readl(PRCMU_TIMER_4_DOWNCOUNT); > + count2 = readl(PRCMU_TIMER_4_DOWNCOUNT); > + } while (count2 != count); What's the point of this exercise ? > + clocksource_calc_mult_shift(&clocksource_db8500_prcmu, > + RATE_32K, SCHED_CLOCK_MIN_WRAP); > + clocksource_register(&clocksource_db8500_prcmu); Please use clocksource_register_hz() > diff --git a/include/linux/clksrc-db8500-prcmu.h b/include/linux/clksrc-db8500-prcmu.h > new file mode 100644 > index 0000000..42b8587 > --- /dev/null > +++ b/include/linux/clksrc-db8500-prcmu.h Huch, why needs this to be a separate head in include/linux ? > @@ -0,0 +1,17 @@ > +/* > + * Copyright (C) ST-Ericsson SA 2011 > + * > + * License Terms: GNU General Public License v2 > + * Author: Mattias Wallin > + * > + */ > +#ifndef __CLKSRC_DB8500_PRCMU_H > +#define __CLKSRC_DB8500_PRCMU_H > + > +#ifdef CONFIG_CLKSRC_DB8500_PRCMU > +void __init clksrc_db8500_prcmu_init(void); > +#else > +void __init clksrc_db8500_prcmu_init(void) {} > +#endif > + > +#endif > -- > 1.7.4.3 > >