Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mach-u300: cleanup clockevent code
Date: Wed, 1 Jun 2011 10:34:46 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1106011027360.3078@ionos> (raw)
In-Reply-To: <BANLkTi=UyypKZUQOCCL-KWyAbMQBKY4ccg@mail.gmail.com>



On Wed, 1 Jun 2011, Linus Walleij wrote:

> 2011/5/31 Thomas Gleixner <tglx@linutronix.de>:
> > On Tue, 31 May 2011, Linus Walleij wrote:
> >> From: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> Use the new clockevents_config_and_register() function to register
> >> the U300 clockevent, since that code requires ->cpumask to be set
> >> we set this even on this UP system to please the framework.
> >
> > Hmm, how about whacking the framework maintainer on the head for that
> > requirement?
> 
> Yeah hm, I sort of figured it might be desirable to have this warning
> on SMP. This:
> 
> BUG_ON(!dev->cpumask);
> 
> from clockevents.c is the culprit anyway. I dunno if it's best to
> #ifdef CONFIG_SMP that thing (technically I guess it shouldn't
> even be in the struct on UP but who cares) or if there is some
> more clever way to do it runtime, so whatever you prefer, I can
> patch it if you know what you want.

We need it even on UP for the &!^%$@ broadcast mechanism to avoid a
massive ifdef mess there :(

But yeah, we can make it conditional for SMP and simply set
cpumask_of(0) in the UP case.

Thanks,

	tglx

  reply	other threads:[~2011-06-01  8:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 21:09 [PATCH 3/3] mach-u300: cleanup clockevent code Linus Walleij
2011-05-31 21:23 ` Thomas Gleixner
2011-06-01  7:37   ` Linus Walleij
2011-06-01  8:34     ` Thomas Gleixner [this message]
2011-06-01  8:53       ` Linus Walleij
2011-06-01  9:22       ` Russell King - ARM Linux
2011-06-01 10:03         ` Thomas Gleixner
2011-06-01 11:23           ` Linus Walleij
2011-06-02  1:51           ` Stephen Boyd
2011-06-02  9:35             ` Thomas Gleixner
2011-06-02 10:29               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1106011027360.3078@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox