linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kprobes: Fix build error in test code
Date: Wed, 9 Nov 2011 11:17:51 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1111091117230.3307@xanadu.home> (raw)
In-Reply-To: <1320834975.2427.7.camel@linaro1>

On Wed, 9 Nov 2011, Jon Medhurst (Tixy) wrote:

> On Wed, 2011-10-19 at 10:47 +0100, Jon Medhurst (Tixy) wrote:
> > When compiling kprobes-test-thumb.c an error like below may occur:
> > 
> > /tmp/ccKcuJcG.s:19179: Error: offset out of range
> > 
> > This is caused by the compiler underestimating the size of the inline
> > assembler instructions containing ".space 0x1000" and failing to spill
> > the literal pool in time to prevent the generation of PC relative load
> > instruction with invalid offsets.
> > 
> > The fix implemented by this patch is to replace a single large .space
> > directive by a number of 4 byte .space's. This requires splitting the
> > macros which generate test cases for branch instructions into two forms:
> > one with, and one without support for inserting extra code between
> > branch and target.
> > 
> > Signed-off-by: Jon Medhurst <jon.medhurst@linaro.org>
> > ---
> 
> Nicolas, I noticed that you put this patch into the Linaro kernel tree,
> can I take that as an Acked-by? ;-)

Sure.


Nicolas

      reply	other threads:[~2011-11-09 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19  9:47 [PATCH] ARM: kprobes: Fix build error in test code Jon Medhurst (Tixy)
2011-11-09 10:36 ` Jon Medhurst (Tixy)
2011-11-09 16:17   ` Nicolas Pitre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1111091117230.3307@xanadu.home \
    --to=nicolas.pitre@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).