From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Add optimised swahb32() byteswap helper for v6 and above
Date: Wed, 23 Nov 2011 11:09:00 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.02.1111231108330.17904@xanadu.home> (raw)
In-Reply-To: <1322059345-18842-1-git-send-email-dave.martin@linaro.org>
On Wed, 23 Nov 2011, Dave Martin wrote:
> ARMv6 and later processors have the REV16 instruction, which swaps
> the bytes within each halfword of a register value.
>
> This is already used to implement swab16(), but since the native
> operation performaed by REV16 is actually swahb32(), this patch
> renames the existing swab16() helper accordingly and defines
> __arch_swab16() in terms of it. This allows calls to both swab16()
> and swahb32() to be optimised.
>
> The compiler's generated code might improve someday, but as of
> 4.5.2 the code generated for pure C implementing these 16-bit
> bytesswaps remains pessimal.
>
> swahb32() is useful for converting 32-bit Thumb instructions
> between integer and memory representation on BE8 platforms (among
> other uses).
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
Reviewed-by: Nicolas Pitre <nico@linaro.org>
> ---
> arch/arm/include/asm/swab.h | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/swab.h b/arch/arm/include/asm/swab.h
> index 9997ad2..32ee164 100644
> --- a/arch/arm/include/asm/swab.h
> +++ b/arch/arm/include/asm/swab.h
> @@ -24,12 +24,13 @@
>
> #if defined(__KERNEL__) && __LINUX_ARM_ARCH__ >= 6
>
> -static inline __attribute_const__ __u16 __arch_swab16(__u16 x)
> +static inline __attribute_const__ __u32 __arch_swahb32(__u32 x)
> {
> __asm__ ("rev16 %0, %1" : "=r" (x) : "r" (x));
> return x;
> }
> -#define __arch_swab16 __arch_swab16
> +#define __arch_swahb32 __arch_swahb32
> +#define __arch_swab16(x) ((__u16)__arch_swahb32(x))
>
> static inline __attribute_const__ __u32 __arch_swab32(__u32 x)
> {
> --
> 1.7.4.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2011-11-23 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 14:42 [PATCH] ARM: Add optimised swahb32() byteswap helper for v6 and above Dave Martin
2011-11-23 16:09 ` Nicolas Pitre [this message]
2011-11-25 10:12 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1111231108330.17904@xanadu.home \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox