From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: Bug#651215: Kernel fails to boot on NSLU2
Date: Wed, 7 Dec 2011 19:10:48 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.02.1112071902360.2907@xanadu.home> (raw)
In-Reply-To: <20111207225718.GI14542@n2100.arm.linux.org.uk>
On Wed, 7 Dec 2011, Russell King - ARM Linux wrote:
> On Wed, Dec 07, 2011 at 11:05:58PM +0100, Arnaud Patard wrote:
> > I may be wrong but it seems that arm_dma_zone_size is used before being
> > set. It would be interesting if someone can boot test a nslu2 kernel with
> > appended patch.
>
> It does look like that's the case - arm_dma_zone_size is used in
> arm_bootmem_free(), which is called from bootmem_init() and in turn
> paging_init().
>
> So, arm_dma_zone_size needs to be set before paging_init() is called.
Oops, indeed.
> I'd actually suggest moving it before:
>
> if (mdesc->restart_mode)
> reboot_setup(&mdesc->restart_mode);
>
> so that it's set real early, to avoid any future problems with this.
> The earlier these kinds of things are set, the less likely this kind
> of bug will happen.
Arnaud: please resubmit your patch moving the call as suggested by
Russell and mark it with:
Acked-by: Nicolas Pitre <nico@linaro.org>
and
CC: stable at kernel.org
Thanks
Nicolas
prev parent reply other threads:[~2011-12-08 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111206194048.12063.82586.reportbug@vrnul03074nb.vr-netze.vrnet>
2011-12-07 6:02 ` Bug#651215: Kernel fails to boot on NSLU2 Ben Hutchings
2011-12-07 22:05 ` Arnaud Patard (Rtp)
2011-12-07 22:57 ` Russell King - ARM Linux
2011-12-08 0:10 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1112071902360.2907@xanadu.home \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).