From: nico@fluxnic.net (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: rwlocks: remove unused branch labels from trylock routines
Date: Fri, 22 Jun 2012 16:22:20 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.02.1206221621350.10229@xanadu.home> (raw)
In-Reply-To: <1340378146-17560-3-git-send-email-will.deacon@arm.com>
On Fri, 22 Jun 2012, Will Deacon wrote:
> The ARM arch_{read,write}_trylock implementations include unused
> backwards branch labels, since we don't retry the locking operation
> if the exclusive store fails.
>
> This patch removes the labels.
>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
> arch/arm/include/asm/spinlock.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/spinlock.h b/arch/arm/include/asm/spinlock.h
> index dcca638..aa7945b 100644
> --- a/arch/arm/include/asm/spinlock.h
> +++ b/arch/arm/include/asm/spinlock.h
> @@ -183,7 +183,7 @@ static inline int arch_write_trylock(arch_rwlock_t *rw)
> unsigned long tmp;
>
> __asm__ __volatile__(
> -"1: ldrex %0, [%1]\n"
> +" ldrex %0, [%1]\n"
> " teq %0, #0\n"
> " strexeq %0, %2, [%1]"
> : "=&r" (tmp)
> @@ -269,7 +269,7 @@ static inline int arch_read_trylock(arch_rwlock_t *rw)
> unsigned long tmp, tmp2 = 1;
>
> __asm__ __volatile__(
> -"1: ldrex %0, [%2]\n"
> +" ldrex %0, [%2]\n"
> " adds %0, %0, #1\n"
> " strexpl %1, %0, [%2]\n"
> : "=&r" (tmp), "+r" (tmp2)
> --
> 1.7.4.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2012-06-22 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:15 [PATCH 0/2] Implement ticket spinlocks for ARM Will Deacon
2012-06-22 15:15 ` [PATCH 1/2] ARM: spinlock: use ticket algorithm for ARMv6+ locking implementation Will Deacon
2012-06-22 20:08 ` Nicolas Pitre
2012-06-25 9:36 ` Will Deacon
2012-06-22 15:15 ` [PATCH 2/2] ARM: rwlocks: remove unused branch labels from trylock routines Will Deacon
2012-06-22 20:22 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1206221621350.10229@xanadu.home \
--to=nico@fluxnic.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).