linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nico@fluxnic.net (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: omap2: use get_auxcr for aux ctrl register read
Date: Wed, 16 Jan 2013 23:41:17 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1301162340421.6300@xanadu.home> (raw)
In-Reply-To: <1358391205-23943-3-git-send-email-robherring2@gmail.com>

On Wed, 16 Jan 2013, Rob Herring wrote:

> From: Rob Herring <rob.herring@calxeda.com>
> 
> Use get_auxcr instead of inline assembly to read the CP15 aux ctrl
> register.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>

Looks trivial enough.

Acked-by: Nicolas Pitre <nico@linaro.org>


> ---
>  arch/arm/mach-omap2/pm34xx.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 7be3622..bef8ef6 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -33,6 +33,7 @@
>  
>  #include <trace/events/power.h>
>  
> +#include <asm/cp15.h>
>  #include <asm/fncpy.h>
>  #include <asm/suspend.h>
>  #include <asm/system_misc.h>
> @@ -216,9 +217,8 @@ static void omap34xx_save_context(u32 *save)
>  	u32 val;
>  
>  	/* Read Auxiliary Control Register */
> -	asm("mrc p15, 0, %0, c1, c0, 1" : "=r" (val));
>  	*save++ = 1;
> -	*save++ = val;
> +	*save++ = get_auxcr();
>  
>  	/* Read L2 AUX ctrl register */
>  	asm("mrc p15, 1, %0, c9, c0, 2" : "=r" (val));
> -- 
> 1.7.10.4
> 

  reply	other threads:[~2013-01-17  4:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17  2:53 [PATCH 1/3] ARM: introduce common set_auxcr/get_auxcr functions Rob Herring
2013-01-17  2:53 ` [PATCH 2/3] ARM: convert platform hotplug inline assembly to C Rob Herring
2013-01-17  4:40   ` Nicolas Pitre
2013-01-17 14:18     ` Rob Herring
2013-01-17 15:42       ` Nicolas Pitre
2013-01-18  3:34         ` Rob Herring
2013-01-18  4:56           ` Nicolas Pitre
2013-01-17  2:53 ` [PATCH 3/3] ARM: omap2: use get_auxcr for aux ctrl register read Rob Herring
2013-01-17  4:41   ` Nicolas Pitre [this message]
2013-01-17  8:30   ` Santosh Shilimkar
2013-01-17 17:07     ` Tony Lindgren
2013-01-17  4:34 ` [PATCH 1/3] ARM: introduce common set_auxcr/get_auxcr functions Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1301162340421.6300@xanadu.home \
    --to=nico@fluxnic.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).