[PATCH] irqchip: add support for Marvell Orion SoCs

Arnd Bergmann
2013-05-02T19:11:40Z

On Thursday 02 May 2013, Jason Gunthorpe wrote:
> > +static struct of_device_id orion_irq_dt_ids[] __initconst = {
> > + { .compatible = "marvell,orion-mpic", .data = orion_of_init },
> > + { }
>
> Is there a strong reason to change the compatible string? Looks to me
> like either the new driver or the old driver will bind depending on
> what is in the machine description. No need for a new string?
>

The compatible string should change if the binding changes in an
incomptible way, and we should try not to change it unless it's
fundamentally flawed.

Arnd