From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: hisi: fix hip04 build without HOTPLUG_CPU
Date: Tue, 19 May 2015 16:36:32 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1505191635450.4843@knanqh.ubzr> (raw)
In-Reply-To: <5060758.bQYeG67z55@wuerfel>
On Tue, 19 May 2015, Arnd Bergmann wrote:
> The hip04 smp implementation provides the hotplug operations (cpu_die
> and cpu_kill) unconditionally at the moment, which leads to a build
> error when HOTPLUG_CPU is disabled:
>
> mach-hisi/platmcpm.c:242:13: note: (near initialization for 'hip04_smp_ops')
> mach-hisi/platmcpm.c:242:2: error: unknown field 'cpu_die' specified in initializer
> mach-hisi/platmcpm.c:243:2: error: unknown field 'cpu_kill' specified in initializer
>
> This uses an #ifdef to remove the code from the build when that
> option is not set.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 905cdf9dda5d ("ARM: hisi/hip04: remove the MCPM overhead")
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
> The patch causing this is currently part of rmk's devel-stable branch.
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index 880cbfa9c343..b5f8f5ffda79 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -152,6 +152,7 @@ out:
> return 0;
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> static void hip04_cpu_die(unsigned int l_cpu)
> {
> unsigned int mpidr, cpu, cluster;
> @@ -236,11 +237,14 @@ err:
> spin_unlock_irq(&boot_lock);
> return 0;
> }
> +#endif
>
> static struct smp_operations __initdata hip04_smp_ops = {
> .smp_boot_secondary = hip04_boot_secondary,
> +#ifdef CONFIG_HOTPLUG_CPU
> .cpu_die = hip04_cpu_die,
> .cpu_kill = hip04_cpu_kill,
> +#endif
> };
>
> static bool __init hip04_cpu_table_init(void)
>
>
next prev parent reply other threads:[~2015-05-19 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 20:33 [PATCH] ARM: hisi: fix hip04 build without HOTPLUG_CPU Arnd Bergmann
2015-05-19 20:36 ` Nicolas Pitre [this message]
2015-05-20 9:57 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1505191635450.4843@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox