From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: appropriate __init annotation for const data
Date: Mon, 27 Jul 2015 17:42:08 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1507271740030.1806@knanqh.ubzr> (raw)
In-Reply-To: <CAOMZO5DAMNh=Wfr=BzxMsRGiHofUBVUemUD2sfO3MEx7LkJRAQ@mail.gmail.com>
On Mon, 27 Jul 2015, Fabio Estevam wrote:
> On Mon, Jul 27, 2015 at 6:15 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> >
> > Init data marked const should be annotated with __initconst for
>
> > diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> > index 2e7cec86e5..1063af930d 100644
> > --- a/arch/arm/mach-mxs/mach-mxs.c
> > +++ b/arch/arm/mach-mxs/mach-mxs.c
> > @@ -282,7 +282,7 @@ static void __init apx4devkit_init(void)
> > #define TX28_FEC_PHY_RESET MXS_GPIO_NR(4, 13)
> > #define TX28_FEC_nINT MXS_GPIO_NR(4, 5)
> >
> > -static const struct gpio tx28_gpios[] __initconst = {
> > +static const struct gpio const tx28_gpios[] __initconst = {
> > { ENET0_MDC__GPIO_4_0, GPIOF_OUT_INIT_LOW, "GPIO_4_0" },
> > { ENET0_MDIO__GPIO_4_1, GPIOF_OUT_INIT_LOW, "GPIO_4_1" },
> > { ENET0_RX_EN__GPIO_4_2, GPIOF_OUT_INIT_LOW, "GPIO_4_2" },
> > @@ -528,7 +528,7 @@ static void mxs_restart(enum reboot_mode mode, const char *cmd)
> > soft_restart(0);
> > }
> >
> > -static const char *mxs_dt_compat[] __initdata = {
> > +static const char *mxs_dt_compat[] __initconst = {
^
A "const" is still missing here.
Argh...
Nicolas
prev parent reply other threads:[~2015-07-27 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 21:15 [PATCH v2] ARM: appropriate __init annotation for const data Nicolas Pitre
2015-07-27 21:29 ` Fabio Estevam
2015-07-27 21:42 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1507271740030.1806@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox