From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.pitre@linaro.org (Nicolas Pitre) Date: Sun, 2 Apr 2017 11:44:45 -0400 (EDT) Subject: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file In-Reply-To: References: <20170401222119.25106-1-nicolas.pitre@linaro.org> <20170401222119.25106-5-nicolas.pitre@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2 Apr 2017, Andy Shevchenko wrote: > On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre wrote: > > This contains code that is common between serial_core.c and the > > minitty code to come. Mainly helper functions used by UART drivers. > > > I have two questions: > - why minitty (what is that by the way?) can't use serial_core.c as a library? See patch 5/5. It is a compatible replacement for serial_core.c and the entire TTY layer collapsed into the smallest code possible, and the result is itself smaller than serial_core.c alone. > - does -M -C help to make this diff shorter? No it doesn't. Maybe I should have mentioned that there is no functional change resulting from this patch. Nicolas