From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AB2C10F14 for ; Sat, 12 Oct 2019 15:01:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BC5206CD for ; Sat, 12 Oct 2019 15:01:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nBx4ke+3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z40kAoLX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53BC5206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YBIcx29ubYJKrHuAQP712y37mX8hq+s2NxWstWADnuU=; b=nBx4ke+3lRYMA7un9euMl92ka NR6zFQpp7DYTi2dZgzE6TsNDgjOlOVYKG0PHGWU/jKUuh+bnyrdK6P4HDGKg1EnoRqiJyt4CkTO3c OJ00mYFSkQt7odGo+2MeRrPrDgsuBB13KSQzoPbHejoanOykAjUfIz1YFJC5DzVM+N+/b5bYtFopL JEUusC/L+uY7KUH0H42YTQaPLhf8AJVS0srwT4TtTW7Qxr1nyg+CqsjaF7JfEwjttvOqhpaHHBfm+ 8rUQO2WrDofebnNRxV/5NO/OVf9BhyO3gI07aYe/sMN4Gaq7DB3u9Ccz/cSuAmNwXv22df7dSQ0l1 ttuLjB0PQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJItY-00088g-OR; Sat, 12 Oct 2019 15:01:24 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJItQ-00083a-J9; Sat, 12 Oct 2019 15:01:17 +0000 Received: by mail-wr1-x443.google.com with SMTP id y19so14898768wrd.3; Sat, 12 Oct 2019 08:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=wVHcI9lSX8uaanGOnUjTf6lBkgZpFUQiHj5D28R77UI=; b=Z40kAoLXOa7xNeMlvgjV/XN8StTUUqzxN+pH0LjQpN9c4e/UkTuBbt26vsmjr5uqRj 4YMMxQ+eHT22lGwozUzw8P9hyw97FaX7Qj4RhdbFgjkNoQ+pIv6HTrJHiBvhcCu6aW/R D304+7rWRCWMSCd6OtCCLA0qvDiwwaLzYQl5Dri6dTMVMkxn+Oazp+4NFKYLfYKT2tK+ lWp1UUUol393Oqr2L+PNLOC71Uv7Zp9kxH+tsvMbj0WT+5kecjiuSvRA1DwcLUreVE9S ubLwyURpWBG8OLEjGEqYG45IMtXOxhkdKxGQR4XlPWRiMxBdY8+jq/bMJO4lwV2N2YfT Ukgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=wVHcI9lSX8uaanGOnUjTf6lBkgZpFUQiHj5D28R77UI=; b=jmj60mZs8JYBmxVpXZonSQbVNHhdvDAVZq5Dij0eNZOYEiLg334br34ruys8XV6Hpa o+4fb/5kayi0dxUUrwBFpKvqpx/QIyTennTNRcF0vW7l8ZSJlC8mQgosDcVGIjw09A7T MDu93jSv9lEKiud6Datz2gN1OomWN6eRk2aSnz9qEFK/vf38/fVBMVprpB0vLI0IeB5C qokKln0o8xI11q4JQCtUn86rTFh/bMvw/ZTdbn6LcHbR+tgvUVRfN86TH6exlCHNsb+2 jETjjlfsvtQqQkKjnRLZGN3eY3ux1rDS+lYJRz5X6fIgQ4psllv9BombJA5jhg40Y30e FjtA== X-Gm-Message-State: APjAAAWolWDDBCu4Bg1jzD/uRY50FtCMBLoxj46jv4iA0C69mpyfERqX h6WbrVMHhLL0kIv6aM0+Zw== X-Google-Smtp-Source: APXvYqyPqpqzbP3XnFoMi2/Pw8QbR40wew29pTMGd6u41ZdKzpdyoEoKHixDywvu/gSA1r4Y94rusw== X-Received: by 2002:adf:bd8f:: with SMTP id l15mr17498773wrh.362.1570892473305; Sat, 12 Oct 2019 08:01:13 -0700 (PDT) Received: from ninjabhubz.org (host-2-102-13-201.as13285.net. [2.102.13.201]) by smtp.gmail.com with ESMTPSA id u2sm5154279wml.44.2019.10.12.08.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2019 08:01:12 -0700 (PDT) From: Jules Irenge X-Google-Original-From: Jules Irenge Date: Sat, 12 Oct 2019 16:00:59 +0100 (BST) To: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line In-Reply-To: Message-ID: References: <20191011212745.20262-1-jbi.octave@gmail.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191012_080116_632445_C5F9F235 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jules Irenge , f.fainelli@gmail.com, sbranden@broadcom.com, mchehab+samsung@kernel.org, outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, eric@anholt.net, daniela.mormocea@gmail.com, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, dave.stevenson@raspberrypi.org, rjui@broadcom.com, hverkuil-cisco@xs4all.nl, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Oct 2019, Julia Lawall wrote: > > > On Fri, 11 Oct 2019, Jules Irenge wrote: > >> Fix warning of logical continuations should be on the previous line. >> Issue detected by checkpatch tool. > > There seem to be several changes mixed together in this patch. > > Don't have a subject line that is identical to a line in the log message. > The subject line should be short. > > Keeping the arguments of && on the same line, but breaking the line after > a == doesn't seem to be a good idea. It would be better to have the left > argument of == on one line and the right argument on another, if that is > needed. > > julia > Apology, Yesterday was my bday, I was reckless. I am resending now. Please do not hesitate to give me a feedback if possible. Thanks Jules _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel