From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B2BC4CECE for ; Sun, 13 Oct 2019 19:02:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53CEB20679 for ; Sun, 13 Oct 2019 19:02:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VjcHLKdR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pmiduzxg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53CEB20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5UQw6KpQFguQv/LkTsP1sHx5OT04VCM5kjhW00pbTg8=; b=VjcHLKdRM3CLmd OJR4how4Nv8LiRVH+VhHnvzWriy8+BwQaE+lCotovbzfulvo501XB6J7QperwAyYRmElIKFWKaKsd yP02v9ywkARjnIUuS08eX1WKxfWAlakllh6fM1kTjOPagb1REcR99xt2nBGqy5LY1JwSU5JGTteCE A05tre2DIZkUz46rzVv3T5MzVnyMF3eBAZC6e1er6SnpNeCTzaScSym1QjuoPHpg6LoTMM3jTx9AF FeCfeLZXK93EnVw2mgB7SrZehKb63sVYGNDbZMW2ehtfQOiUSigjPyeKOEHJuKmDgP+WVuB2uEAzs SBMUTRaaw+RYMyUfmEdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJj8K-00014T-3L; Sun, 13 Oct 2019 19:02:24 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJj8G-00013g-Jz; Sun, 13 Oct 2019 19:02:21 +0000 Received: by mail-wr1-x441.google.com with SMTP id j18so17139001wrq.10; Sun, 13 Oct 2019 12:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=PxCXXBhA2C4YLbbTIZsjjSPm4uyCjLfswHazHo9DGq8=; b=PmiduzxgZfYZ4Y4miFLkBY+Tvs4U8DF0tCoOdP6wlSkN/AU0MkesEU1lPjXphgh6lI noVBN680XLK9ZWCPkAFIR0BYJ/DUjzyOmf5H+9Fyv0hdDDCUNBdrK15k/APgabD1a0bZ Fj2wih9jCXW9zok/Oja5/1BCrCkjxiIQBYyq35bzaMjis57OIJn1T8b4UKuII8elh92p rzn3YMGVArTbuIu86t/iu4/fAgGxUI0DIBi/8lZ5KgiqI6th8FDG1D6ncWkwW3nb4KKR MBI9biz7oh1SxCMyZnqC4lGoGphiyZlMis+EUj+hnWq1TjcfP6KBjzN8ZHRlaR5Hc5ho RlrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=PxCXXBhA2C4YLbbTIZsjjSPm4uyCjLfswHazHo9DGq8=; b=ts4cQDmiPDljyTz8aatW0GCZ82G226KXmxt8xzsbKv3L59F81k5BQLWpPpRBcQXLaF ml6rUbdlu1ddIn+U4iSYr0npl6FlobYEZ8aRFcZlgREDS9t6Zgi4xkNmK+UiHB9IEJPT jOdyfFUvmUjZcDMkdiJ8gmhLVfCEn7B0w1oSVQIUm8Ex6wo60LzYR1TpEsAP1KjIsQyx Fq0y1DtsxCg+wARiHrsNSMKGaE9ys2Yk9lqSGtUUHhs0KXTtKd4OdOTDu0MJRCW3JoDA z26XH/tzwOZ9xMpY9x8y3jYNJdQEgEYDf7OcWjDNTabI6UsY1/clRmjoW8B7QOloRUgf PUrg== X-Gm-Message-State: APjAAAVUdBU3noV4ECOwAvagD9rEpoXiYsxtXXjS2VLsvidmmnQI0cQc A8da+Wb9kfJa0wO8rirr2w== X-Google-Smtp-Source: APXvYqwRDKLOg2xklbQug/Q9fbWTVahN4YcnnUI3vsVlqSyRaAe/iK25TsO7xBQ0WNFWVQ1TSZIO9g== X-Received: by 2002:adf:f983:: with SMTP id f3mr22369431wrr.169.1570993338769; Sun, 13 Oct 2019 12:02:18 -0700 (PDT) Received: from ninjabhubz.org (host-2-102-13-201.as13285.net. [2.102.13.201]) by smtp.gmail.com with ESMTPSA id s1sm23055438wrg.80.2019.10.13.12.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2019 12:02:18 -0700 (PDT) From: Jules Irenge X-Google-Original-From: Jules Irenge Date: Sun, 13 Oct 2019 20:02:04 +0100 (BST) To: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis In-Reply-To: Message-ID: References: <20191013183420.13785-1-jbi.octave@gmail.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191013_120220_676874_88DC424A X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jules Irenge , f.fainelli@gmail.com, sbranden@broadcom.com, mchehab+samsung@kernel.org, outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, eric@anholt.net, daniela.mormocea@gmail.com, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, dave.stevenson@raspberrypi.org, rjui@broadcom.com, hverkuil-cisco@xs4all.nl, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 13 Oct 2019, Julia Lawall wrote: > > > On Sun, 13 Oct 2019, Jules Irenge wrote: > > > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > > In the process, change driver functions name in the multiple files from: > > vchiq_mmal_port_parameter_set to vmp_prmtr_set > > vchiq_mmal_component_disable to vm_cmpnt_disable > > vchiq_mmal_port_connect_tunnel to vmp_cnnct_tunnel > > vchiq_mmal_component_enable to vm_cmpnt_enable > > You should say why you change the names. > > As far as I can see, there is no change to the actual function > definitions, so the code can't compile. Perhaps that comes later in the > series, but the elements of the series have to be ordered such that > compilation is possible after each patch. > > julia > Thanks for the feedback, I am updating it and will be compiling each point. Jules _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel