Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ulli.kroll@googlemail.com (Hans Ulli Kroll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge
Date: Sun, 5 Feb 2017 11:00:41 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1702051054240.26313@T420s> (raw)
In-Reply-To: <20170128204839.18330-2-linus.walleij@linaro.org>

Hi Linus

while debugging my boot issues on my NAS 4220, I saw this warning

irq: type mismatch, failed to map hwirq-26 for /soc/interrupt-controller at 48000000!

We need to use the use the use the PCI IRQ from gemini as root for the irq 
domain, not the next one in DT.

diff --git a/drivers/pci/host/pci-gemini.c b/drivers/pci/host/pci-gemini.c
index 7051dd992114..bb564a8e6379 100644
--- a/drivers/pci/host/pci-gemini.c
+++ b/drivers/pci/host/pci-gemini.c
@@ -217,7 +217,6 @@ static const struct irq_domain_ops gemini_pci_irqdomain_ops = {
 
 static int gemini_pci_setup_irq(struct gemini_pci *p, int irq)
 {
-	struct device_node *intc = of_get_next_child(p->dev->of_node, NULL);
 	int i;
 
 	if (!intc) {
@@ -225,7 +224,7 @@ static int gemini_pci_setup_irq(struct gemini_pci *p, int irq)
 		return -EINVAL;
 	}
 
-	p->irqdomain = irq_domain_add_linear(intc, 4,
+	p->irqdomain = irq_domain_add_linear(p->dev->of_node, 4,
 					     &gemini_pci_irqdomain_ops,
 					     p);
 	if (!p->irqdomain) {
-- 
2.11.0

  parent reply	other threads:[~2017-02-05 10:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 20:48 [PATCH 1/4] PCI: add DT bindings for Cortina Gemini PCI Host Bridge Linus Walleij
2017-01-28 20:48 ` [PATCH 2/4] PCI: add driver for Cortina Gemini " Linus Walleij
2017-01-31  0:37   ` Bjorn Helgaas
2017-02-26 19:42     ` Linus Walleij
2017-02-27 16:49       ` Bjorn Helgaas
2017-02-01 11:11   ` Arnd Bergmann
2017-02-04 18:43     ` Linus Walleij
2017-02-16 14:08       ` Arnd Bergmann
2017-02-18 14:05         ` Linus Walleij
2017-02-05 10:00   ` Hans Ulli Kroll [this message]
2017-02-05 14:36     ` Linus Walleij
2017-01-28 20:48 ` [PATCH 3/4] ARM: gemini: select MIGHT_HAVE_PCI Linus Walleij
2017-01-28 20:48 ` [PATCH 4/4] ARM: dts: add PCI to the Gemini DTSI Linus Walleij
2017-02-05 10:03   ` Hans Ulli Kroll
2017-02-05 15:00     ` Linus Walleij
2017-02-06  9:55       ` Hans Ulli Kroll
2017-02-10 15:40         ` Arnd Bergmann
2017-02-11 11:17           ` Linus Walleij
2017-01-31  0:31 ` [PATCH 1/4] PCI: add DT bindings for Cortina Gemini PCI Host Bridge Bjorn Helgaas
2017-02-01 20:00   ` Linus Walleij
2017-02-01 11:09 ` Arnd Bergmann
2017-02-05 14:44   ` Linus Walleij
2017-02-01 11:19 ` Arnd Bergmann
2017-02-05 14:56   ` Linus Walleij
2017-02-06 16:05     ` Arnd Bergmann
2017-02-01 16:02 ` Rob Herring
2017-02-01 20:04   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1702051054240.26313@T420s \
    --to=ulli.kroll@googlemail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox