From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D507C433DB for ; Mon, 28 Dec 2020 06:47:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7576207BC for ; Mon, 28 Dec 2020 06:47:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7576207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MKP1YOMPJ2ul1wax4sVMysQoWZxCe6qflNlXkmIVbPI=; b=prR6h/MDyvk2gSqtETsRzmto+ 8q9TN7yIAHXkGAHfpWq8Nh4flGoXoThsi/ardZ6oBjkhbTBdrh0giIBKzpvPQxYVd6RLTPxAar7TK ug6Cnj9QohcJAgA409aes17pMU1lLxg9k5IMeI3vxWkrg+EJbZxXVFnjMxiUWdiLtaopQmpBReX6J IBr31IBS+cRaX1SUNB1HgrcgEG/uCUJBdAp7G2pAnblV+AYKaHYqmoAfVnBIeOV6r5ZaMe6sUu9z8 kAS+EvCJ/cRzX6j8EE8aBtvwTpDKHvf3+5pFZHhxTJGSre/sHoqUPPSvHfO9fMWQsw69HG/TnGUSR wrfkPDATA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktmGK-0002WS-Jp; Mon, 28 Dec 2020 06:44:12 +0000 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktmGH-0002VC-NC for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 06:44:10 +0000 Received: by mail-oo1-xc33.google.com with SMTP id x23so2032075oop.1 for ; Sun, 27 Dec 2020 22:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=o5wtPX61QoOqoZU2VTRJCE3ZyQ3KdZXG3FjCWYnhbEo=; b=MBH2w4ZV23RJuSVoaMPfo6ofBhwPb4jewXSeYQP1woVvN0xBSyjZWO4V96+cOKOtnL 3jCjNCOgv3I+YECgRSpVULJVXQhGZt1uchfOt8BAsCMtx4C+2cBR+qkrCkamned2He46 SERg4fDJusnUBrJhqRzLq8ROXsSy5J3dYE1Lsw33VAELTQKK/p2FE36yScc77AOXTzQb UfNXx60MJaNTev25LrjbWQPq5vj8uYXozn3xWo6THV0WcAAa5fYKiCU+eDYVV5mIs3d8 chsppqTQkqI/DyVSrSPfw3Hv8Mw3rI6rw4gj7SbSKMSIGfcGEaoiZtFuCKpEKFkFC+A+ i7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=o5wtPX61QoOqoZU2VTRJCE3ZyQ3KdZXG3FjCWYnhbEo=; b=hon+tiOQ5NKPp09xsT7WIz6shvyj4q7LlKxeBnr6r8a4TeJxL50sPQ52l5GYQCRzZR dHb6SsGbctk4+/H3tYkmvy9LxqYPYkkLsNS50iIKEgO0ZHX9CusVeoGDh8c0GABhVJ+B /i9m4H5v6+tBqH8z36xhJuAbg3rGth6O32myK1EwI5d5/Xwt61tmqBhe23kG31wKok02 khfJVWWgRYWsBIAndVaoZg2XAJx9dhH0jbgV/r1Eg0Cy6qmE1LoMKaNJdZV9TZa/sEGi q0RZ1KYRaG+ceBuIBLyCTNUY/ec8+J7pd1eD+4rUJw3llngTS1I5V6neSIQo6aaufZE7 jrjw== X-Gm-Message-State: AOAM533Qdbdm1d3sUGn0p7LW7mqOz33gxdXUpQ7peCPMU60jMS++KaJt 6KKfa5mZaYbUuWap0zDFogd7dg== X-Google-Smtp-Source: ABdhPJxptFi0jlfOZ1KQ6ymnKZrDWvFuVR0GjxXiDxg91Uwd+ugMtO2uhXZ+YCY0rcz1P04NWG54nw== X-Received: by 2002:a4a:cb84:: with SMTP id y4mr29970687ooq.70.1609137842984; Sun, 27 Dec 2020 22:44:02 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l134sm8666271oig.25.2020.12.27.22.44.01 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Sun, 27 Dec 2020 22:44:02 -0800 (PST) Date: Sun, 27 Dec 2020 22:43:44 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting In-Reply-To: Message-ID: References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> <20201227234853.5mjyxcybucts3kbq@box> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_014409_870808_DB578610 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Android Kernel Team , Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , Linux Kernel Mailing List , Matthew Wilcox , Linux-MM , Vinayak Menon , Linux ARM , "Kirill A. Shutemov" , Andrew Morton , Will Deacon , "Kirill A. Shutemov" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 27 Dec 2020, Linus Torvalds wrote: > On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov wrote: > > > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > > large, but take a look. > > Ok, it's not that much bigger, and the end result is certainly much > clearer wrt locking. > > So that last version of yours with the fix for the uninitialized 'ret' > variable looks good to me. > > Of course, I've said that before, and have been wrong. So ... And guess what... it's broken. I folded it into testing rc1: segfault on cc1, systemd "Journal file corrupted, rotating", seen on more than one machine. I've backed it out, rc1 itself seems fine, I'll leave rc1 under load overnight, then come back to the faultaround patch tomorrow; won't glance at it tonight, but maybe Kirill will guess what's wrong. Hugh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel