public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mbenes@suse.cz (Miroslav Benes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] arm64: implement live patching
Date: Tue, 6 Nov 2018 17:49:07 +0100 (CET)	[thread overview]
Message-ID: <alpine.LSU.2.21.1811061745440.30614@pobox.suse.cz> (raw)
In-Reply-To: <20181026142152.5F0D868C95@newverein.lst.de>

Hi,

On Fri, 26 Oct 2018, Torsten Duwe wrote:

> Based on ftrace with regs, do the usual thing.
> (see Documentation/livepatch/livepatch.txt)
> 
> Use task flag bit 6 to track patch transisiton state for the consistency
> model. Add it to the work mask so it gets cleared on all kernel exits to
> userland.
> 
> Tell livepatch regs->pc is the place to change the return address.
> Make sure the graph tracer call hook is only called on the final function
> entry in case regs->pc gets modified after an interception.
> 
> Signed-off-by: Torsten Duwe <duwe@suse.de>

It looks good now apart from arm64 asm part which should be reviewed by 
someone else.

However, could you summarize our analysis regarding post-module-load calls 
of apply_relocate_add() in the commit log, please? It is important for 
future reference.

Thanks,
Miroslav

  reply	other threads:[~2018-11-06 16:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 14:20 [PATCH v4 0/3] arm64 live patching Torsten Duwe
2018-10-26 14:21 ` [PATCH v4 1/3] arm64: implement ftrace with regs Torsten Duwe
2018-10-31 12:10   ` Mark Rutland
2018-10-31 13:19     ` Jiri Kosina
2018-10-31 14:18       ` Mark Rutland
2018-10-31 17:58         ` Torsten Duwe
2018-11-08 12:12   ` Ard Biesheuvel
2018-11-12 11:51     ` Torsten Duwe
2018-10-26 14:21 ` [PATCH v4 2/3] arm64: implement live patching Torsten Duwe
2018-11-06 16:49   ` Miroslav Benes [this message]
2018-11-08 12:42   ` Ard Biesheuvel
2018-11-12 11:01     ` Torsten Duwe
2018-11-12 11:06       ` Ard Biesheuvel
2018-10-26 14:21 ` [PATCH v4 3/3] arm64: reliable stacktraces Torsten Duwe
2018-10-26 15:37   ` Josh Poimboeuf
2018-10-29  9:28     ` Mark Rutland
2018-10-29 15:42       ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.1811061745440.30614@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox