From mboxrd@z Thu Jan  1 00:00:00 1970
From: chad.dupuis@qlogic.com (Chad Dupuis)
Date: Wed, 7 Oct 2015 14:49:22 -0400
Subject: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable
In-Reply-To: <56151E03.4050908@redhat.com>
References: <5002023.QHmpbQ8s70@wuerfel> <56151E03.4050908@redhat.com>
Message-ID: <alpine.OSX.2.00.1510071441460.1714@dns1.prod.a4.vary.redhat.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org



On Wed, 7 Oct 2015, Maurizio Lombardi wrote:

> Hi,
>
> On 10/07/2015 03:11 PM, Arnd Bergmann wrote:
>> -	memset(&npiv_tbl, 0, sizeof(npiv_tbl));
>> -	if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl))
>> +	npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL);
>> +	if (!npiv_tbl)
>>  		goto done;
>>
>
> If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
>

The enablement of the fcoe interface can still proceed if this particular 
allocation fails so returning 0 would be appropriate here.

This patch looks good to me.

>
> Regards,
> Maurizio Lombardi
>