From: Will Deacon <will@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org,
david@kernel.org, liam@infradead.org, Dev Jain <dev.jain@arm.com>,
catalin.marinas@arm.com, kernel-team@android.com,
riel@surriel.com, vbabka@kernel.org, harry@kernel.org,
jannh@google.com, lance.yang@linux.dev, kas@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
apopple@nvidia.com, rcampbell@nvidia.com, ziy@nvidia.com,
matthew.brost@intel.com, joshua.hahnjy@gmail.com,
rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net,
ying.huang@linux.alibaba.com, ak@linux.intel.com,
nao.horiguchi@gmail.com, mel@csn.ul.ie, j-nomura@ce.jp.nec.com,
pfalcato@suse.de, tglx@kernel.org, dave.hansen@intel.com,
jpoimboe@kernel.org, linux-arm-kernel@lists.infradead.org,
ryan.roberts@arm.com, anshuman.khandual@arm.com
Subject: Re: [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries
Date: Wed, 22 Jul 2026 12:30:52 +0100 [thread overview]
Message-ID: <amCp7L1AxoeDH1Yg@willie-the-truck> (raw)
In-Reply-To: <20260721133636.df1a012df895054d3fd34a2e@linux-foundation.org>
On Tue, Jul 21, 2026 at 01:36:36PM -0700, Andrew Morton wrote:
> On Tue, 21 Jul 2026 18:18:38 +0100 Will Deacon <will@kernel.org> wrote:
>
> > On Fri, 03 Jul 2026 11:41:53 +0000, Dev Jain wrote:
> > > There are various places which use ptep_get() to get the pte entry
> > > corresponding to a hugetlb folio. Some arches (like s390) have special
> > > handling to compute the pteval, so they provide huge_ptep_get(). Use this
> > > helper consistently.
> > >
> > > Additionally, some code paths may provide huge_ptep_get with an unaligned
> > > address. This is a problem on arm64 (I checked other arches and it looks
> > > fine for them), which is fixed in patch 1. The fix is made to be
> > > to huge_ptep_get() - that is wider churn and we can do that later.
> > >
> > > [...]
> >
> > Applied first patch to arm64 (for-next/fixes), thanks!
> >
> > [1/6] arm64: make huge_ptep_get handled unaligned addresses
> > https://git.kernel.org/arm64/c/9175a8c7cfe88
> >
> > I'm hoping Andrew can drop this from the mm tree to avoid a duplicate,
> > but I didn't hear back yet and I'd like to land the fix.
>
> I can redo Dev's series to omit [1/6]. The patches apply that way, but
> there might be build-time or runtime issues running the other patches
> without [1/6] present, haven't looked.
>
> Also, review indicates that the changelog requires updating
> (https://lore.kernel.org/all/2b9d60a2-8698-46b0-80ae-b8747a66a85b@kernel.org/)
> and I believe that Dev plans to do that.
There's been no update for two weeks, so I wouldn't hold your breath!
> IOW, it would be better to carry this in mm.git with your ack.
>
> Do you plan to upstream this in 7.2-rcX? If so then I can hang onto
> this patch until it appears in mainline. Or something.
Yes, I'd like to get this (just this first patch!) in for -rc5 so I
picked it into the arm64 fixes branch.
Will
prev parent reply other threads:[~2026-07-22 11:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 11:41 [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries Dev Jain
2026-07-03 11:41 ` [PATCH v3 1/6] arm64: make huge_ptep_get handled unaligned addresses Dev Jain
2026-07-04 2:42 ` Muchun Song
2026-07-05 7:35 ` Andrew Morton
2026-07-05 8:08 ` Dev Jain
2026-07-06 8:45 ` David Hildenbrand (Arm)
2026-07-06 10:52 ` Dev Jain
2026-07-06 10:54 ` Dev Jain
2026-07-06 14:04 ` David Hildenbrand (Arm)
2026-07-16 12:49 ` Will Deacon
2026-07-03 11:41 ` [PATCH v3 2/6] mm/rmap: use huge_ptep_get() in try_to_unmap_one() Dev Jain
2026-07-04 2:44 ` Muchun Song
2026-07-06 8:46 ` David Hildenbrand (Arm)
2026-07-03 11:41 ` [PATCH v3 3/6] mm/rmap: use huge_ptep_get() in try_to_migrate_one() Dev Jain
2026-07-06 8:46 ` David Hildenbrand (Arm)
2026-07-03 11:41 ` [PATCH v3 4/6] mm/migrate: use huge_ptep_get() in remove_migration_pte() Dev Jain
2026-07-03 11:41 ` [PATCH v3 5/6] mm/page_vma_mapped: use huge_ptep_get() for hugetlb Dev Jain
2026-07-03 11:41 ` [PATCH v3 6/6] mm/mprotect: " Dev Jain
2026-07-05 8:33 ` Andrew Morton
2026-07-05 8:47 ` Dev Jain
2026-07-06 8:48 ` David Hildenbrand (Arm)
2026-07-05 7:45 ` [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries Andrew Morton
2026-07-21 17:18 ` Will Deacon
2026-07-21 20:36 ` Andrew Morton
2026-07-22 4:33 ` Dev Jain
2026-07-22 11:52 ` Will Deacon
2026-07-22 11:30 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amCp7L1AxoeDH1Yg@willie-the-truck \
--to=will@kernel.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=gourry@gourry.net \
--cc=harry@kernel.org \
--cc=j-nomura@ce.jp.nec.com \
--cc=jannh@google.com \
--cc=joshua.hahnjy@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=kas@kernel.org \
--cc=kernel-team@android.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=matthew.brost@intel.com \
--cc=mel@csn.ul.ie \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=pfalcato@suse.de \
--cc=rakie.kim@sk.com \
--cc=rcampbell@nvidia.com \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=tglx@kernel.org \
--cc=vbabka@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox