Re: [PATCH net-next 2/2] net: stmmac: Don't rely on the PHY for flow-control testing

[Oleksij Rempel <o.rempel@pengutronix.de>]

On Tue, Jul 28, 2026 at 05:57:27PM +0200, Maxime Chevallier wrote:
> For flow-control testing in loopback mode, we don't need to ask what the
> PHY is currently using as pause/asym settings. The PHY is no longer
> involved in selftest, we rely strictly on MAC loopback. We therefore

In case of the Full-Duplex, Link-wide PAUSE (IEEE 802.3 Annex 31B),
the PHY is not involved in actual flow control. PHY role is limited only
to autoneg part - announce own and receive link partners caps.

With this reasoning this patch will have more weight, i guess :)

> only need to know if the MAC supports Symmetric pause for the test, as
> we exercise both TX and RX pause support in the selftest.
> 
> Remove phydev requirement for flowcontrol selftest as well as the
> AsymPause requirement.

This is currently the weak point of generic and stmmac selftests,
we actually need to force the link in some specific state.

On the PHY side we would need to enabled force link mode (disable
autoneg) and bypass link-up status (PHY may still signal link down)

> With that, we can also drop the linux/phy.h include.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Otherwise, LGTM:
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you!

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |