Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Peng Fan <peng.fan@nxp.com>, Frank Li <Frank.Li@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Daniel Baluta <daniel.baluta@oss.nxp.com>,
	Francesco Dolcini <francesco@dolcini.it>,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: remoteproc: imx_rproc: document optional "memory-region-names"
Date: Thu, 30 Jul 2026 14:14:06 -0400	[thread overview]
Message-ID: <amuUbkDM60eFzvJo@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260730163412.1145-2-laurentiumihalcea111@gmail.com>

On Thu, Jul 30, 2026 at 09:34:09AM -0700, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> The carveout region names are derived based on the DT node names. Because
> of this, the DT node names are ABI, which is not supposed to happen.
>
> Fix this by documenting an additional, optional property:
> "memory-region-names". This way, the software will have a way to build the
> carveout region names without relying on the DT node names.

"After update all existing DT tree, this will be required.

>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---

Additional information to help understand why it is important.

1. at thread wrong use vdevbuffer insteand vdev0buffer as node name
https://lore.kernel.org/imx/20260705202439.3F5771F000E9@smtp.kernel.org/
2. similar case happen at
https://lore.kernel.org/imx/20260715071741.79CA81F000E9@smtp.kernel.org/

Suppose these problem should be detected by dt binding check instead of
sashkio ai.


>  .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index c18f71b64889..8e3e6676a95e 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -62,6 +62,10 @@ properties:
>      minItems: 1
>      maxItems: 32
>
> +  memory-region-names:
> +    minItems: 1
> +    maxItems: 32
> +

Need restrict names

  memory-region-names:
    description:
      Names for the memory-region phandles. Each entry must be one of the
      following recognized names. "vdev0buffer" is the shared buffer for
      virtio device 0, handled automatically by the rproc virtio framework.
      "vdev<n>ring<n>" (e.g. "vdev0vring0", "vdev0vring1") are the virtio
      vring buffers for device N, also managed by the virtio framework.
      "rsc-table" is the resource table region used to share the resource
      table between Linux and the remote processor when it is pre-loaded in
      memory. All other entries are treated as generic carveout regions that
      are mapped and made available to the remote processor.
    minItems: 1
    maxItems: 32
    items:
      anyOf:
        - const: rsc-table
        - pattern: "^vdev[0-9]+buffer$"
        - pattern: "^vdev[0-9]+vring[0-9]+$"

Frank

>    power-domains:
>      minItems: 2
>      maxItems: 8
> --
> 2.53.0
>


  reply	other threads:[~2026-07-30 18:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 16:34 [PATCH v3 0/4] Add RPROC support for the MX95-15x15-FRDM board Laurentiu Mihalcea
2026-07-30 16:34 ` [PATCH v3 1/4] dt-bindings: remoteproc: imx_rproc: document optional "memory-region-names" Laurentiu Mihalcea
2026-07-30 18:14   ` Frank Li [this message]
2026-07-31  9:37   ` Krzysztof Kozlowski
2026-07-31  9:39     ` Krzysztof Kozlowski
2026-07-31 14:34       ` Frank Li
2026-07-30 16:34 ` [PATCH v3 2/4] remoteproc: imx_rpoc: fix carveout name parsing Laurentiu Mihalcea
2026-07-30 16:58   ` Frank Li
2026-07-31  9:38   ` Krzysztof Kozlowski
2026-07-30 16:34 ` [PATCH v3 3/4] arm64: dts: freescale: imx95-15x15-frdm: remove some rmem regions Laurentiu Mihalcea
2026-07-30 16:34 ` [PATCH v3 4/4] arm64: dts: freescale: add DT overlay for MX95-15x15-FRDM RPMSG usage Laurentiu Mihalcea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amuUbkDM60eFzvJo@lizhi-Precision-Tower-5810 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=laurentiumihalcea111@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox