From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Dileep Kumar Nagavarapu <DileepKumar.Nagavarapu@amd.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Michal Simek" <michal.simek@amd.com>,
"Conall O'Griofa" <conall.ogriofa@amd.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com,
"Sai Krishna Potthuri" <sai.krishna.potthuri@amd.com>
Subject: Re: [PATCH v3 3/6] iio: adc: xilinx-xadc: Split driver into core and platform files
Date: Thu, 30 Jul 2026 21:52:24 +0200 [thread overview]
Message-ID: <amuqm5qdzXqKutPS@monoceros> (raw)
In-Reply-To: <20260729125455.95893-4-DileepKumar.Nagavarapu@amd.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Hello,
On Wed, Jul 29, 2026 at 06:24:52PM +0530, Dileep Kumar Nagavarapu wrote:
> @@ -19,21 +19,13 @@
> #include <linux/err.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
I wonder why so many people recently add <linux/mod_devicetable.h> in
their patches. Is there some tool that suggests that?
Anyhow: Please don't. <linux/platform_device.h> is already enough to get
of_device_id (which is the only *_device_id this driver is using unless
I missed something).
linux/mod_devicetable.h will hopefully go away soon, so each patch
adding an #include for it is annoying.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-30 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 12:54 [PATCH v3 0/6] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard Dileep Kumar Nagavarapu
2026-07-29 12:54 ` [PATCH v3 1/6] iio: adc: xilinx-xadc: Modernize driver code Dileep Kumar Nagavarapu
2026-07-29 13:43 ` Pandey, Radhey Shyam
2026-07-29 14:43 ` Joshua Crofts
2026-07-29 12:54 ` [PATCH v3 2/6] iio: adc: xilinx-xadc: Add helper functions for the device setup Dileep Kumar Nagavarapu
2026-07-29 12:54 ` [PATCH v3 3/6] iio: adc: xilinx-xadc: Split driver into core and platform files Dileep Kumar Nagavarapu
2026-07-30 19:52 ` Uwe Kleine-König [this message]
2026-07-29 12:54 ` [PATCH v3 4/6] iio: adc: xilinx-xadc: Add .setup_channels() to struct xadc_ops Dileep Kumar Nagavarapu
2026-07-29 12:54 ` [PATCH v3 5/6] iio: adc: xilinx-xadc: Add I2C interface support Dileep Kumar Nagavarapu
2026-07-29 12:54 ` [PATCH v3 6/6] iio: adc: xilinx-xadc: Correct Write edge in CFG Dileep Kumar Nagavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amuqm5qdzXqKutPS@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=DileepKumar.Nagavarapu@amd.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=dlechner@baylibre.com \
--cc=git@amd.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=sai.krishna.potthuri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox