From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: proximity: add driver for Sharp GP2AP070S proximity sensor
Date: Thu, 30 Jul 2026 21:54:23 +0200 [thread overview]
Message-ID: <amurhVbZi_y0N55n@monoceros> (raw)
In-Reply-To: <20260731-gp2ap070s-v2-2-1bdfee07d5ea@disroot.org>
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
Hello,
On Fri, Jul 31, 2026 at 01:01:30AM +0530, Kaustabh Chakraborty wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>
<linux/i2c.h> is enough to get the definitions for i2c_device_id and
of_device_id. Please rely on that and don't explicitly add an include
for <linux/mod_devicetable.h>. The latter is a dependency hell and is
going away soon.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-30 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 19:31 [PATCH v2 0/3] Add Sharp GP2AP070S Proximity Driver and enable it in Galaxy J6 (j6lte) Kaustabh Chakraborty
2026-07-30 19:31 ` [PATCH v2 1/3] dt-bindings: iio: proximity: add Sharp GP2AP070S proximity sensor Kaustabh Chakraborty
2026-07-30 19:31 ` [PATCH v2 2/3] iio: proximity: add driver for " Kaustabh Chakraborty
2026-07-30 19:36 ` Kaustabh Chakraborty
2026-07-30 19:54 ` Uwe Kleine-König [this message]
2026-07-30 19:31 ` [PATCH v2 3/3] arm64: dts: exynos7870-j6lte: add " Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amurhVbZi_y0N55n@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=alim.akhtar@samsung.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kauschluss@disroot.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox