From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 022FAC5516D for ; Fri, 31 Jul 2026 14:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9p5H84h8x8Hryd5laooWlYLONK2AUymxXq30i/XtKzU=; b=0WkGkNj2kLKJ09Ui/I9oK/Zs/B DNIiKNjCA4+InQ4ztbb4W6QpKgbDYiiwl392vhUHwDW8Chd05R6L09LhdnbDY1KMO7b6ovvLUOyFq JWoSzhbtwxSnEyhSkqo2ZYdDjuYZ5Jx//mW3Ue3KkhZsyjKnsbYuculmMBHLmlhH9njnpoV6qT4wF GwGuL4MhC28XkJuREh1B3+1QkRnP0SNDzx7/85IdmPVO1jd6OL5aSZPjov2CJfFaa4vk6M+bNbeaL KkKRDhvFX3e3J8s35pVQXZTz13usse81mVuJm3cZXnWki2VzDy0yjrLUbeoojiWcE2qYLVNAtGOhl XNpIsvfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpoVC-0000000CoxB-1Nf9; Fri, 31 Jul 2026 14:46:22 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpoUb-0000000Cosx-49Kv for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2026 14:45:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bP6G0zKoKuChnwUp6Ms1JKeU5Mum0bvonsDDoeReszfZcRZbImYcZpPfrlme12QMUyGigM/v6jbJc2wRfTrxDyXvbmtOEzCtAQNXsMxDyJQvekkQ/nIMprQZ7pHSqyqgHyFltMghroT8g60HObUzvwsSWjNXSbbRXYD8BaG+/u09AybZlMnlWVa0wtoMsGpf3ZktCIxS41dmLzr/4Zxzo7byUkitxG2cAENmGs/mCfaNpYHbkCtx0P1pwzpxUhriUQCdbXfrpelW2KJElacGFumc7Fhw7GFBf5RLXVxIBuvziFBXw0Ne2XTqMjoL3zhX3VXBW1txj//urTg8dhHtEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9p5H84h8x8Hryd5laooWlYLONK2AUymxXq30i/XtKzU=; b=mTwlF3uArcP7XUId6XmJx2NURk3i2ik1NdQ8JCh9F3IWrcq7GyrORA0FzBU0ksM9bbfvbAZKlQYRvbhVaaTvAPKXEn4GkQA9u8wO/GTvf+CkLsnb63IJrS1cFxxEqO5H0Icy64afjXDHuDd8NMjL8Jg6sy7FcwrgtY92mR+AIemC9969p9VUJHjN6sumxotfb/q7EAyLTw1FTwzR84DFjqs+Ki5LUVQDqCqbELgdBND5CHPA473ySyGMEffsjbG4OCNix8SToN2PnXdoLjdsu5YlyifdfrD2mtCAJagzWC+a7YZ9YT8m0XPbj3amNQKlUXl3lfWj7rfgsvPbtqL++w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9p5H84h8x8Hryd5laooWlYLONK2AUymxXq30i/XtKzU=; b=J+P7CtInvSG3UiUFzE38B59RkImWQqwGwi6Uhf9JAeFVRoxYIk70AVAoUE+9C70N6/anMZmfpdEmnXMPtGwfQO/RgjVvUj9v+8qNXH151e0KITAXWF4E/oMqrcK/h3i/SYt0/lCQ/i5u8hV5I0q8rZQqcykQMbdVF18zrSHV5oFWPuhLc2Wfit2Th3M7Xc6PjkBpkg83nOyK4yAPhqWRLArHRPVoVnMBj3huvAtrFBkUzVz9ERZlOj6OWo87gaTg+rmkcPXY8DY+2g0b3+cCXac+lZXQI9aUeGCyhNFA5qnpo7mieR0VnEjdE/zDjT25Tevk6OCRembnbf7qNJLY6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by PAXPR04MB8656.eurprd04.prod.outlook.com (2603:10a6:102:21f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.15; Fri, 31 Jul 2026 14:45:41 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%7]) with mapi id 15.21.0270.012; Fri, 31 Jul 2026 14:45:41 +0000 Date: Fri, 31 Jul 2026 09:45:32 -0500 From: Frank Li To: Pan Chuang Cc: Peter Griffin , =?iso-8859-1?Q?Andr=E9?= Draszik , Tudor Ambarus , Thinh Nguyen , Greg Kroah-Hartman , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "moderated list:GOOGLE TENSOR SoC SUPPORT" , "open list:GOOGLE TENSOR SoC SUPPORT" , "open list:DESIGNWARE USB3 DRD IP DRIVER" , open list , "open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OMAP USB SUPPORT" Subject: Re: [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Message-ID: References: <20260731035448.252289-1-panchuang@vivo.com> <20260731035448.252289-5-panchuang@vivo.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731035448.252289-5-panchuang@vivo.com> X-ClientProxiedBy: SN7P220CA0008.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::13) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|PAXPR04MB8656:EE_ X-MS-Office365-Filtering-Correlation-Id: 20df4294-b650-480e-1192-08deef126481 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|23010399003|376014|7416014|366016|1800799024|6133799003|10067099003|11063799006|56012099006|4143699003|5023799004|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: eV4OjNZPjaOP5zDvTfugLmsQjOcyLyAQCRXIrcxaWkyQqr9o3xYxmT8o5sA51zVWENrdg5PezWM3xac5gs6qWHXyuFt7KtPdhCgqGmUWUkCa6HpuflAFIUXNfJlaVHXDENRh6H36XEpE2PbusvHba8zJvKnYqVKcm/qt/BV/OWMvoXrrgZ4z67aIKfupYHIVOI4eQG8Zr0RgzY4O5cFiVnspEyg9zmDOC9ZtD0p2frpZ3/SIO0nsKL5UWWl9gDQYtvfHXq90Fjl/DRJJ8u8G5BG5q/KdcBXf6ADLxiLrc/yQ7Ar+zldGZBljVpNkVk46XeuAehU2ydik9HclGBdf98JWP+0x4Dht4jAeHgCPe1VJ8R4VAt/sHlYLY9wCI7YIS722io/1SH38nLUv/Rfo4ekQOcmTY/IY7lR7Pmn9yA29LZpuEzqIuKSJTC2liLAANQ/Ycai/wxos7qWl7ljsCYLucBBTEOXGUCFeiCpPOzw3RuFCXGsxFBF5QVtWjEXWMAljsevZ7OCmDoT7qC3+xCNz9nyyIwLS3zsFSFucvvjF6Bh7Ep+6XkQ5OKJbJUSJO1ar4qV3N1UTdMde3UZS9Ej6OdVQ7AY3WxIvqc4RrmCFlFaGroxoCkwDVjplMgsVAdhksy9OQQlncb3TXwxwNReT+INyknu6xA0dwkx3s+Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(23010399003)(376014)(7416014)(366016)(1800799024)(6133799003)(10067099003)(11063799006)(56012099006)(4143699003)(5023799004)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gVIjXal9EmnsdlDhUSooyy32w2tVBL3r9+bbhnu4E4wCqzXlz1D8wyIdiPvy?= =?us-ascii?Q?IUPBLwTP7rUkwtLSrpeYYtIFTNJRzbbc430DY15SQ8OBtRFdCZnhuSGopmcF?= =?us-ascii?Q?r1heBkwFMo1Q/Q74BP8bzR4b4kqFKAjRzFtdBDKMKJQrxd7ndtnQuf+xgPZJ?= =?us-ascii?Q?mAwBzuoDR4zMV+De8bnvlWdNPM3oWoaXkTVLw2tcp3mg6LaPasrV1DSLAMv4?= =?us-ascii?Q?ZivnyqZWSwx/p4iSqWHuylgK1LMjINHF9I0xqX6KI87op7tjtBQUSYLPE1c1?= =?us-ascii?Q?2X9f2xMW9dAnZvrVUrXpur79J0jT2h6goZXAoFS9+5Ksg7kCOVfUEDWpa+oJ?= =?us-ascii?Q?lFgwP/Q1K25dxvwGKVokxNRGvneqtgBPQ5FQVJAEfsHzWUChBat3QhRxXjzm?= =?us-ascii?Q?lPQyQAPtqBxC6CDirjeo+/rxZbrmf0UfqanJnPyKPrlyPccupuS474Iis9j1?= =?us-ascii?Q?XrkdFPFLSxo5O0n1dUIDe01khjW8chesMIetgZEdpGeAHU6FoGOsNw1THFzg?= =?us-ascii?Q?b0+elG3j3yxA4pJv4pW9b4mW0GDFEAz+j5p4p7yRISEoHextWdhTLb8NQMEE?= =?us-ascii?Q?EPnujY5ihdq72Ueas6CNMLfLSbfVYVQFmqIyGmAISKf8OQJm4KeWwZ1PvOZP?= =?us-ascii?Q?5K6D5stht976aH/4c1TJk65+rwE+fpnF94dI/wTTOAl3VZn5BB2YT9UvEyCy?= =?us-ascii?Q?8/MKp+lhUOkIB4Kc9JF/7yXjQjGKG5fLNplwxVccJ2uHQ89uMyyZXQjS5F/y?= =?us-ascii?Q?/B1lJeEfc2D2FJDY1C8SPw5HmANSKfEhyR+SbWTjlIqZ+NuThV5Ih5WTPFkZ?= =?us-ascii?Q?qXqur1WIJYmqWeU6n7i4nbpCJmlwGb8ZPPAjYYTcksq17Z2TJPfohEPKUXQ/?= =?us-ascii?Q?YvTdvEmIaE6rAhDnD3pOEmpKjWv/vdFLZb+Kxmfj2HgkNZE8CGw+cp/dYqsm?= =?us-ascii?Q?xABtf+q0B2/s89C48oYtVnlYNyyFKzmMtXHKx+VvmS2Qr21ehE8ud1xB0V8I?= =?us-ascii?Q?aYndvkM6WMKMLTo3ZDjoWUF0Ba0cIlR9y5soTR58NOiVyKZzQFijZCOc5FjG?= =?us-ascii?Q?Xf1T+omZCBKikdeOoiQteKyVQzfp44RUaiWmaYrvV9nR+XOFSADcsHQ7jdQU?= =?us-ascii?Q?n4j6kFguhueTbmTnnWMWpvPy2bqlu26GUaXljRwJxQle6KEaYqGgOLGL5CcH?= =?us-ascii?Q?qDzMFyaCjofc22fdOIRPaSTZVVT+ZZwrhRNywxX1vJr8xbmm5O6QP0exTv0E?= =?us-ascii?Q?y+lR4ONVC2d+JadfW96WbihGAwtvF1CqN1T0XNV4zHB/SeOkbZFCVehyEAo3?= =?us-ascii?Q?uCAVn/ueecqvphD/Co+I9eZk4YQNzqPvbNX6s2wNxpWMJkW3t47XWgWPKcBL?= =?us-ascii?Q?54uQ4bEw2RFxp2ez5kPlS4/Ba8QEB6dg4DNBRgofPCEUqySNLvsL4UOpma6C?= =?us-ascii?Q?QobsvrLojFRFrZ9LYNURYr3SxTQG8wmqEDkS25eAUFrlfdxPgz6+A7tCTO1o?= =?us-ascii?Q?x77cwClVEIBlS+3BwizRpN320uGq37kCUxb0IV99beboljPdAHKJS+5KZ0uv?= =?us-ascii?Q?MUM/dnYdnxax20bOR/lC4xEYBgpdyfspljooFf9s6BTLpULPqFfTGbN7Skkc?= =?us-ascii?Q?fMS354t/tGhPpZXcR78R/skVq6uifx+cCetZ6bWDC+ev6SPVEQkfbX19Ugzv?= =?us-ascii?Q?hTiPbK5msFTc0PhcJBHR1BR+xN6YCwJBmji5e6KNWfnUO+1tDhNR+GtSXEfT?= =?us-ascii?Q?WvYle/9AXUZWGKZf2EIx6uEVCDc8q0qtrMQA/QCnPQVopsJoPfrD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20df4294-b650-480e-1192-08deef126481 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2026 14:45:41.0835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BZA+wKsGm6z+PDINcVp57MiPQ8uwHVywBmH/kC/OC1UIo7uC+zSBHxUNUtMfaKiXReB59MzCe1dGZYDauqUITlYNLfaINfg57m0SOEZ0DCQPROo/35fkcU1vbNlxweQm X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8656 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260731_074546_077092_EF2A7AB3 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 31, 2026 at 11:54:38AM +0800, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), > devm_request_irq() and devm_request_threaded_irq() automatically log > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() and dev_err_probe() calls. > > Signed-off-by: Pan Chuang > --- > drivers/usb/dwc3/dwc3-google.c | 4 +--- > drivers/usb/dwc3/dwc3-imx.c | 2 +- > drivers/usb/dwc3/dwc3-imx8mp.c | 4 +--- for imx part Acked-by: Frank Li > drivers/usb/dwc3/dwc3-keystone.c | 5 +---- > drivers/usb/dwc3/dwc3-omap.c | 5 +---- > 5 files changed, 5 insertions(+), 15 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c > index 60ee4cc99b28..e581d407b872 100644 > --- a/drivers/usb/dwc3/dwc3-google.c > +++ b/drivers/usb/dwc3/dwc3-google.c > @@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d > dwc3_google_resume_irq, > IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > req_name, google); > - if (ret < 0) { > - dev_err(google->dev, "failed to request irq %s\n", req_name); > + if (ret < 0) > return ret; > - } > > return irq; > } > diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c > index 973a486b544d..d967acd43d44 100644 > --- a/drivers/usb/dwc3/dwc3-imx.c > +++ b/drivers/usb/dwc3/dwc3-imx.c > @@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev) > IRQF_ONESHOT | IRQF_NO_AUTOEN, > irq_name, dwc_imx); > if (ret) > - return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq); > + return ret; > > ret = device_add_software_node(dev, &dwc3_imx_swnode); > if (ret) > diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c > index 1cf96540b66e..ee92a5efaa6e 100644 > --- a/drivers/usb/dwc3/dwc3-imx8mp.c > +++ b/drivers/usb/dwc3/dwc3-imx8mp.c > @@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev) > > err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt, > IRQF_ONESHOT, dev_name(dev), dwc3_imx); > - if (err) { > - dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err); > + if (err) > goto put_dwc3; > - } > > device_set_wakeup_capable(dev, true); > pm_runtime_put(dev); > diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c > index 7ee1610162b9..8ad302abe883 100644 > --- a/drivers/usb/dwc3/dwc3-keystone.c > +++ b/drivers/usb/dwc3/dwc3-keystone.c > @@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev) > > error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED, > dev_name(dev), kdwc); > - if (error) { > - dev_err(dev, "failed to request IRQ #%d --> %d\n", > - irq, error); > + if (error) > goto err_irq; > - } > > kdwc3_enable_irqs(kdwc); > > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > index fe74d11bb629..3bff775fbe4e 100644 > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc3-omap.c > @@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt, > dwc3_omap_interrupt_thread, IRQF_SHARED, > "dwc3-omap", omap); > - if (ret) { > - dev_err(dev, "failed to request IRQ #%d --> %d\n", > - omap->irq, ret); > + if (ret) > goto err2; > - } > dwc3_omap_enable_irqs(omap); > return 0; > > -- > 2.34.1 > >