From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sasha Finkelstein <k@chaosmail.tech>
Cc: Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Neal Gompa <neal@gompa.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Alyssa Milburn <amilburn@zall.org>
Subject: Re: [PATCH v2 2/3] usb: typec: tipd: Factor out i2c specifics
Date: Wed, 5 Aug 2026 14:40:58 +0200 [thread overview]
Message-ID: <anMvWrR5E54fPXVV@black.igk.intel.com> (raw)
In-Reply-To: <7D31226B-98F2-4DF2-BA47-31CF9B269A7F@chaosmail.tech>
On Wed, Aug 05, 2026 at 01:57:18PM +0200, Sasha Finkelstein wrote:
> On Aug 5, 2026, at 13:47, Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote:
> >>
> >> -static const struct regmap_config tps6598x_regmap_config = {
> >> +const struct regmap_config tps6598x_regmap_config = {
> >> .reg_bits = 8,
> >> .val_bits = 8,
> >> .max_register = 0x7F,
> >> };
> >> +EXPORT_SYMBOL_GPL(tps6598x_regmap_config);
> >
> > Don't export that. Just move it to i2c.c
>
> I use this one in spmi.c too, the regmap configuration is the same,
> just the backend is different
Ah, sorry I missed that.
Thanks,
--
heikki
next prev parent reply other threads:[~2026-08-05 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 16:09 [PATCH v2 0/3] usb: typec: tipd: Add sn201202x (ACE3) support Sasha Finkelstein
2026-07-27 16:09 ` [PATCH v2 1/3] dt-bindings: usb: tps6598x: Add sn201202x/ACE3 Sasha Finkelstein
2026-07-27 16:09 ` [PATCH v2 2/3] usb: typec: tipd: Factor out i2c specifics Sasha Finkelstein
2026-08-05 11:47 ` Heikki Krogerus
2026-08-05 11:57 ` Sasha Finkelstein
2026-08-05 12:40 ` Heikki Krogerus [this message]
2026-07-27 16:09 ` [PATCH v2 3/3] usb: typec: tipd: Add sn201202x support Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anMvWrR5E54fPXVV@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=amilburn@zall.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=k@chaosmail.tech \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox