Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: shengjiu.wang@oss.nxp.com, lgirdwood@gmail.com,
	broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, shawnguo@kernel.org,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Xiubo.Lee@gmail.com,
	nicoleotsuka@gmail.com, perex@perex.cz, tiwai@suse.com,
	linuxppc-dev@lists.ozlabs.org,
	Shengjiu Wang <shengjiu.wang@nxp.com>
Subject: Re: [PATCH v3 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths
Date: Wed, 5 Aug 2026 12:06:10 -0500	[thread overview]
Message-ID: <anNtgkZYhoWsSRr6@SMW015318> (raw)
In-Reply-To: <CAA+D8ANCoc5qOUvTQPRNkvrfqAY3n6x_fbfUveP8Sfv+SL1NVw@mail.gmail.com>

On Wed, Aug 05, 2026 at 02:57:59PM +0800, Shengjiu Wang wrote:
> On Tue, Aug 4, 2026 at 10:39 PM Frank Li <Frank.li@oss.nxp.com> wrote:
> >
> > On Tue, Aug 04, 2026 at 06:02:14PM +0800, shengjiu.wang@oss.nxp.com wrote:
> > > From: Shengjiu Wang <shengjiu.wang@nxp.com>
> > >
> > > The i.MX ASRC hardware supports up to three conversion pairs (A, B, C).
> > > The existing binding exposed only a single generic audio-graph port,
> > > which cannot represent independent conversion paths when multiple pairs
> > > are in use simultaneously.
> > >
> > > Add a ports container that enumerates up to three sub-ports, each
> > > representing an independent conversion path:
> > >   port@0 -- conversion path 0
> > >   port@1 -- conversion path 1
> > >   port@2 -- conversion path 2
> > >
> > > Each sub-port references audio-graph-port.yaml as before. Hardware pairs
> > > are allocated dynamically at stream open time; each active stream
> > > direction (playback or capture) on a port consumes one hardware pair.
> > >
> > > For backwards compatibility, keep the old single port property but mark
> > > it deprecated. A schema constraint (not: required: [port, ports]) ensures
> > > that both forms cannot be used at the same time. The binding example is
> > > updated to show the preferred ports form.
> > >
> > > No existing upstream DTS file for fsl,imx-asrc uses the previously
> > > documented single 'port' node, so this change does not break any
> > > in-tree device tree.
> >
> > if no existing upstream DTS file use it, you can direct replace with ports
>
> That is to avoid any downstream use of the 'port', so not directly replace it.

Does downstream strictly run DTB_CHECK ?

Frank

>
> best regards
> Shengjiu Wang
>
> >
> > Frank
> >
> > >
> > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > > ---
> > >  .../bindings/sound/fsl,imx-asrc.yaml          | 45 ++++++++++++++++---
> > >  1 file changed, 40 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> > > index 608defc93c1e..67d2826eef3f 100644
> > > --- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> > > +++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> > > @@ -78,9 +78,19 @@ properties:
> > >    power-domains:
> > >      maxItems: 1
> > >
> > > +  ports:
> > > +    $ref: /schemas/graph.yaml#/properties/ports
> > > +    patternProperties:
> > > +      "^port@[0-2]$":
> > > +        $ref: audio-graph-port.yaml#
> > > +        unevaluatedProperties: false
> > > +        description: port for an independent conversion path
> > > +
> > >    port:
> > >      $ref: audio-graph-port.yaml#
> > >      unevaluatedProperties: false
> > > +    deprecated: true
> > > +    description: deprecated, use ports instead
> > >
> > >    fsl,asrc-rate:
> > >      $ref: /schemas/types.yaml#/definitions/uint32
> > > @@ -125,6 +135,10 @@ required:
> > >    - fsl,asrc-width
> > >
> > >  allOf:
> > > +  - not:
> > > +      required:
> > > +        - port
> > > +        - ports
> > >    - $ref: dai-common.yaml#
> > >    - if:
> > >        properties:
> > > @@ -180,11 +194,32 @@ examples:
> > >          fsl,asrc-rate = <48000>;
> > >          fsl,asrc-width = <16>;
> > >
> > > -        port {
> > > -            playback-only;
> > > +        ports {
> > > +            #address-cells = <1>;
> > > +            #size-cells = <0>;
> > > +
> > > +            port@0 {
> > > +                reg = <0>;
> > > +                playback-only;
> > > +                endpoint {
> > > +                    remote-endpoint = <&fe00_ep>;
> > > +                };
> > > +            };
> > > +
> > > +            port@1 {
> > > +                reg = <1>;
> > > +                capture-only;
> > > +                endpoint {
> > > +                    remote-endpoint = <&fe01_ep>;
> > > +                };
> > > +            };
> > >
> > > -            asrc_endpoint: endpoint {
> > > -                remote-endpoint = <&fe00_ep>;
> > > +            port@2 {
> > > +                reg = <2>;
> > > +                capture-only;
> > > +                endpoint {
> > > +                    remote-endpoint = <&fe02_ep>;
> > > +                };
> > >              };
> > > -       };
> > > +        };
> > >      };
> > > --
> > > 2.34.1
> > >
> > >


  reply	other threads:[~2026-08-05 17:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 10:02 [PATCH v3 0/5] ASoC: fsl_asrc/fsl_easrc: expose per-pair/context DAIs and fix DMA race shengjiu.wang
2026-08-04 10:02 ` [PATCH v3 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths shengjiu.wang
2026-08-04 14:39   ` Frank Li
2026-08-05  6:57     ` Shengjiu Wang
2026-08-05 17:06       ` Frank Li [this message]
2026-08-06  5:27         ` Shengjiu Wang
2026-08-06 16:40           ` Frank Li
2026-08-04 10:02 ` [PATCH v3 2/5] ASoC: dt-bindings: fsl,easrc: add ports binding for multiple conversion paths shengjiu.wang
2026-08-04 14:40   ` Frank Li
2026-08-04 10:02 ` [PATCH v3 3/5] ASoC: fsl_asrc/fsl_easrc: move DMA params into pair/context struct shengjiu.wang
2026-08-04 10:02 ` [PATCH v3 4/5] ASoC: fsl_asrc: expose individual DAIs per conversion path shengjiu.wang
2026-08-04 10:02 ` [PATCH v3 5/5] ASoC: fsl_easrc: " shengjiu.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anNtgkZYhoWsSRr6@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=shengjiu.wang@nxp.com \
    --cc=shengjiu.wang@oss.nxp.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox