Re: [PATCH v3] arm64: defconfig: enable Rockchip Multimedia drivers

[Sebastian Reichel <sebastian.reichel@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 5550 bytes --]

Hi,

On Sat, Aug 08, 2026 at 04:06:03PM +0200, Heiko Stübner wrote:
> Am Samstag, 8. August 2026, 02:42:26 Mitteleuropäische Sommerzeit schrieb Sebastian Reichel:
> > Enable multimedia related drivers used by the Radxa ROCK 5B (used as an
> > example, the config options are relevant for most Rockchip RK3588 and
> > RK3576 boards), so that all hardware is supported by the default config.
> > 
> >  * Synopsys MIPI CSI2RX - RK3588 CSI2 Controller
> >  * RKVDEC - RK3588/RK3576 video decoder for H.264 and H.265
> >  * Sony IMX415 - Sensor used by the Radxa Cam 4K module
> >  * Rocket - RK3588 NPU driver
> >  * Verisilicon IOMMU - IOMMU used by RK3588 AV1 video decoder
> >  * Innosilicon CSI D-PHY - RK3588 CSI PHY (one of them)
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> I'm not sure what the actual rule for defconfig changes is.
> 
> In some past thread I remember (hopefully correctly) Krzysztof saying
> that the arm64 defconfig is not supposed to be a distro-config, so
> enabling each and every driver was not the goal.
> 
> On the other hand, he did not repeat that in his reply to your v1 ;-) .

I think its worthwhile to have all board related hardware features
enabled. I've seen too many complains from people that XYZ is not
working that turned out to be simple config problems. With the
defconfig supporting the full hardware there is a known working
config that we can point people towards.

Apart from that KernelCI uses the defconfig for its automated boot
tests. Having full hardware support helps to ensure the drivers are
working as intended and do not regress.

Last but not least the enabled options are consistent with other
platforms. On the video codec side Qualcomm and Mediatek have theirs
enabled, Hantro is also enabled. On the CSI side the Cadence
controller, NXP and Renesas are enabled; I also would expect the
Qualcomm X1E config options once the series from Bryan O'Donoghue
lands. There's also a bunch of camera sensors enabled, which makes
sense since CSI would be useless without them. The only new thing
is the NPU. I argue the main reason for that is that this is a
relatively new thing.

> We're at -rc7 tomorrow, so it'd be 7.4 material anyway, so enough time
> to get "complaints" I guess ;-) .

Correct :)

Greetings,

-- Sebastian

> 
> 
> Heiko
> 
> > ---
> > Changes in v3:
> > - Link to v2: https://patch.msgid.link/20260807-rockchip-defconfig-additions-v2-1-cbb8eef87be6@collabora.com
> > - Also add CONFIG_VIDEO_DW_MIPI_CSI2RX=m and update commit message
> > 
> > Changes in v2:
> > - Link to v1: https://patch.msgid.link/20260806-rockchip-defconfig-additions-v1-0-6b1d8baa0bf5@collabora.com
> > - Squash all patches (Krzysztof Kozlowski)
> > 
> > The Verisilicon IOMMU defconfig change has previously been sent by
> > Benjamin as part of the IOMMU series, but did not reach upstream:
> > 
> > https://lore.kernel.org/all/20260415072349.44237-6-benjamin.gaignard@collabora.com/
> > 
> > The Synopsys CSI controller defconfig change has previously been sent
> > by Michael as part of the driver series, but did not reach upstream:
> > 
> > https://lore.kernel.org/linux-rockchip/20260522-rk3588-vicap-v5-0-d1d1f5265c56@collabora.com/
> > ---
> >  arch/arm64/configs/defconfig | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 654a102cb5bc..49f836ba67a5 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -915,6 +915,7 @@ CONFIG_SDR_PLATFORM_DRIVERS=y
> >  CONFIG_V4L_MEM2MEM_DRIVERS=y
> >  CONFIG_VIDEO_AMPHION_VPU=m
> >  CONFIG_VIDEO_CADENCE_CSI2RX=m
> > +CONFIG_VIDEO_DW_MIPI_CSI2RX=m
> >  CONFIG_VIDEO_WAVE_VPU=m
> >  CONFIG_VIDEO_E5010_JPEG_ENC=m
> >  CONFIG_VIDEO_MEDIATEK_JPEG=m
> > @@ -939,6 +940,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m
> >  CONFIG_VIDEO_RCAR_DRIF=m
> >  CONFIG_VIDEO_ROCKCHIP_RGA=m
> >  CONFIG_VIDEO_ROCKCHIP_CIF=m
> > +CONFIG_VIDEO_ROCKCHIP_VDEC=m
> >  CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC=m
> >  CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
> >  CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
> > @@ -949,6 +951,7 @@ CONFIG_VIDEO_TI_J721E_CSI2RX=m
> >  CONFIG_VIDEO_HANTRO=m
> >  CONFIG_VIDEO_IMX219=m
> >  CONFIG_VIDEO_IMX412=m
> > +CONFIG_VIDEO_IMX415=m
> >  CONFIG_VIDEO_OV5640=m
> >  CONFIG_VIDEO_OV5645=m
> >  CONFIG_VIDEO_S5KJN1=m
> > @@ -1063,6 +1066,8 @@ CONFIG_BACKLIGHT_GPIO=m
> >  CONFIG_LOGO=y
> >  # CONFIG_LOGO_LINUX_MONO is not set
> >  # CONFIG_LOGO_LINUX_VGA16 is not set
> > +CONFIG_DRM_ACCEL=y
> > +CONFIG_DRM_ACCEL_ROCKET=m
> >  CONFIG_SOUND=m
> >  CONFIG_SND=m
> >  CONFIG_SND_ALOOP=m
> > @@ -1611,6 +1616,7 @@ CONFIG_ROCKCHIP_IOMMU=y
> >  CONFIG_TEGRA_IOMMU_SMMU=y
> >  CONFIG_APPLE_DART=m
> >  CONFIG_MTK_IOMMU=y
> > +CONFIG_VSI_IOMMU=m
> >  CONFIG_REMOTEPROC=y
> >  CONFIG_IMX_REMOTEPROC=y
> >  CONFIG_MTK_SCP=m
> > @@ -1785,6 +1791,7 @@ CONFIG_PHY_RZ_G3E_USB3=m
> >  CONFIG_PHY_ROCKCHIP_EMMC=y
> >  CONFIG_PHY_ROCKCHIP_INNO_HDMI=m
> >  CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> > +CONFIG_PHY_ROCKCHIP_INNO_CSIDPHY=m
> >  CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY=m
> >  CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=m
> >  CONFIG_PHY_ROCKCHIP_PCIE=m
> > 
> > ---
> > base-commit: 2d578cd590adc2133aa24496afcd7c3f7f9ba36a
> > change-id: 20260806-rockchip-defconfig-additions-3ef855c4d32e
> > 
> > Best regards,
> > --  
> > Sebastian Reichel <sebastian.reichel@collabora.com>
> > 
> > 
> 
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]