Re: [PATCH net-next v3 2/3] net: stmmac: add tc-mqprio qdisc offload

[Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

> On Sat, 08 Aug 2026 16:49:58 +0200 Lorenzo Bianconi wrote:
> > Subject: [PATCH net-next v3 2/3] net: stmmac: add tc-mqprio qdisc offload
> > 
> > Implement offload of the tc-mqprio qdisc in the stmmac driver. The MTL TX
> > scheduler is switched to strict priority, and the PSTQX/PSTC priority
> > bitmask of each TX queue is programmed from the set of frame priorities
> > mapped to the owning traffic class (qopt->prio_tc_map).
> > 
> > The offload requires the DCB feature and a 1:1 TC to TX queue mapping,
> > with the queue ranges bounded by the number of queues the MAC implements.
> > Configurations with AVB queues are rejected, since forcing strict
> > priority conflicts with the CBS algorithm.
> 
> Clashiko has a bunch of comments, I assume at least one of them is
> actionable. High level - you say "add tc-mqprio qdisc offload"
> but the driver already has a bunch of mqprio code. Background
> would be useful. You also say "1:1 TC to TX queue mapping", if there's
> only one queue per priority why offload mqprio and not prio?
> At least a note in the commit message would be useful.

ack, thx. I will address them in v4.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]