Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Abdurrahman Hussain <abdurrahman@nexthop.ai>
Cc: Michal Simek <michal.simek@amd.com>,
	 Andy Shevchenko <andriy.shevchenko@intel.com>,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: xiic: restore runtime PM teardown in remove to fix clk WARN flood
Date: Tue, 18 Aug 2026 12:16:33 +0200	[thread overview]
Message-ID: <aoQwxxaPSjWD8Zyd@zenone.zhora.eu> (raw)
In-Reply-To: <DKRWHA3VO9S8.3QNFPU0732I1W@nexthop.ai>

Hi Abdurraham,

On Tue, Aug 18, 2026 at 12:44:27AM -0700, Abdurrahman Hussain wrote:
> On Mon Aug 17, 2026 at 12:20 PM PDT, Andi Shyti wrote:
> > A solution would be to drop the managed runtime-PM helper and
> > restore the non managed runtime PM setup and teardown. Otherwise,
> > this ordering issue needs to be addressed in the runtime-PM/clock
> > framework.
> >
> > Does that work?
> >
> > Andi
> 
> Agreed — that's cleaner than special-casing the ordering. v3 drops
> devm_pm_runtime_set_active_enabled() and restores the non-managed
> setup/teardown.
> 
> Let me try it on hardware before sending v3.

Please, also write a nice comment explaining why we won't use the
non managed runtime PM, I don't want to receive in the future a
patch adding the managed runtime PM.

Thanks,
Andi


      reply	other threads:[~2026-08-18 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 18:04 [PATCH v2] i2c: xiic: restore runtime PM teardown in remove to fix clk WARN flood Abdurrahman Hussain
2026-08-16 16:14 ` Andi Shyti
2026-08-16 20:11   ` Abdurrahman Hussain
2026-08-17 19:20     ` Andi Shyti
2026-08-18  7:44       ` Abdurrahman Hussain
2026-08-18 10:16         ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoQwxxaPSjWD8Zyd@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=abdurrahman@nexthop.ai \
    --cc=andriy.shevchenko@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox