From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 699E7C5B572 for ; Wed, 19 Aug 2026 14:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U2eQFn8FaC2ehbiukPPvmqAP1lhAKnJH9RCzVWD7Z9w=; b=Ynq8lPVDLI5WIbmkp0XNLwy558 ncvws81KIOMKgqNXWCmXJv+kgTaazWs5UfIuTahR1q8AYkQ6IWm2F1+Owk5LDmMSIHoH2rTw2QYnE vuVcAUKUFPEpz2LCi6m0+znOvwc9L5WJ5BTN+ruvw+ob8YVOejygTlJxlNA5PfHuSAOFXX5DAxXPO 58OZfuEdRv2i/f0mpnyYjbNhppf+5y0Rf+tGK9shdgYbRclS3bpHlwwlsOmv8HCfrV2TtFlU6klVK hnU1Gnihw5Epq/u4d1mLTUmvtL1AsDhCrs4ai/VMOtvQ6o2AcqDPelUM6jTifx89EBzEsM2wJwQYx 92+2h1sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwhEv-00000009yaG-3WCs; Wed, 19 Aug 2026 14:26:01 +0000 Received: from mail-norwayeastazon11013029.outbound.protection.outlook.com ([40.107.159.29] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwhEt-00000009yZp-31IB for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2026 14:26:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i1lkv2tWmmJ7gwIxDQmMw3nL6P7ZG0FbSnCdPw9brVbdX29XZR0f7UuCsVXrcT+PHOx9DpA3hUGHVB/rU9qaJ3UyIlAy6n8/EicH8w4eM99iut33N4ua8u/bt5rzxNFOiKUQA+WpNpYn/Rq3bJFK91qNX4DwQuiEFunjE/T1sP6NRs2sOhFmyhqLlRN2BkWzvJatbuPeY1CrSWsxYV947y77IPW7e4F3DOoJtMIfUnBzj7eKk3OFndIoME1KWYWgQrJmXRjhXOIb46lstSJhd3A/oTbfhqD1GmEP7N811ctpYXQZdKXvIYiKPKzu2o/EzBLIIr6Tc9v55ei2laLAaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2eQFn8FaC2ehbiukPPvmqAP1lhAKnJH9RCzVWD7Z9w=; b=nMtEDsIgPzA8rdKZAZ4sSLntmc5t+7Y7L0Tzp24D1hdkn0uZoT7+nbsGy/yavTYhWTd1fhohtFvUjIQsCe9tsMN+29QCazIHDTQMxd8xIOTJmWqNd9mH5rs44gZivyXRr0ODSYjp6VYh7FXi7VXoOnVmCvHDbo3SGiBrWtRsSpj+TP6w8gb1ecdFvDC8sgWmc9GLgOZXNHcbA7B4nGS1s0rqCzFfZh9R6AZsxnRpABnuGXFEdNia7y9OJbaolaBvJGmBujx09Yy+NKWNcOKcsYvq3RLI7fH5XSSD7Dh/0jzP9bLZATJ5iP8fe8iz5hO1g5YnCFeM+wavM3mtlHeqFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2eQFn8FaC2ehbiukPPvmqAP1lhAKnJH9RCzVWD7Z9w=; b=Z47A898Mrpxg1TTvrzOaPXmr4nzhjZAdznGbXlKbblqupRi4855XUcD8zxYri2AW4DJ6tIZ91bAl1YGRfYY06uAxZEfRgIHx5Yg+o/k7VFBTD9V4TbYKvY0tutzPy8DsScX27VsfVs2FsFZHcyJ758FwEDoeWapuk5mJ9ilaJWqWFuFDg4NzxP84mE10sU57hfPmcnmX6FM3D3L22QpWZFxviMlbJz4W9SXHtmN9swNYQ7ghrbCtFnsvJ/gRMNwm2kTszF/SWZEutlco+kCfJqTs4PjlxfDpvtYuFofpL0s/uEoil+VvSymMbwc7ndvrIyMBte0VxlwUgqje/vQiOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by DB9PR04MB8462.eurprd04.prod.outlook.com (2603:10a6:10:2cd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.8; Wed, 19 Aug 2026 14:25:54 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%7]) with mapi id 15.21.0339.007; Wed, 19 Aug 2026 14:25:54 +0000 Date: Wed, 19 Aug 2026 09:25:47 -0500 From: Frank Li To: Zhipeng.wang_1@oss.nxp.com Cc: Thomas Gleixner , Marc Zyngier , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jindong Yue , xuegang.liu@nxp.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/5] irqchip/imx-irqsteer: Dispose of parent IRQ mappings in remove() Message-ID: References: <20260819090543.585131-1-Zhipeng.wang_1@oss.nxp.com> <20260819090543.585131-4-Zhipeng.wang_1@oss.nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260819090543.585131-4-Zhipeng.wang_1@oss.nxp.com> X-ClientProxiedBy: SA0PR11CA0064.namprd11.prod.outlook.com (2603:10b6:806:d2::9) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|DB9PR04MB8462:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fa14e99-4e1f-4708-03de-08defdfdc704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|23010399003|376014|56012099006|10067099003|3023799007|22082099003|18002099003|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: NTo4ONPQAIXgRybjdADPToPo+lobBEl25mx8Fre0TSh4V4b9HQAmDpebhyGk7KRC8fhCinj5UqKz2kU/NTvYXt3QeeCA+kDQ+nLjcgxUlsxYlEijmkpcKybCgnx6GFuz/qM1nnUHcF7mZTQ3pXNcoXIr6JtxxBTtlnBGdWc+mWyACjcRBE4N5Q2jN34X5LGo3IRphoftGWT8MHQRkW56eTTgob1kMunnqjpECNjTWfQT+63t0p6Bg7sRPMdNwAPhsCQq1yp1UISXP1N2z8xXKXjHG59n6iqMBlwGLzIY94AeEOx/qAo9YFucXndmtOpiXx67PA1GNWOIJusll3PnpchirVAZdGA0qGvWJkouNGhE7dV8neznihuEDW2pUPj9AZ7jKthp8sOc67jcfe4pGgfsP6IzAFCCnF+ryd+T3OXQj0JMfQL7z4gcVE14MMbmPtpHbbUuXWlaWXiUnrz1fs/AZseoC+N3DMCM/zhthy7Ll3HngOJNa1g55Ul26RkAlzdh8QCTPBUR6JS08ndqgB/DmnODPSnQK8K5dHdY5E5hz3Of7R3r2YhTYEU0EscbDGC5yC04E5m6lTqKXVmVCaSKwwOCUxAin0yV3PJW4nbLEFJ+XJ9xN2j/9SxUntNBBrQVUKDSq6tUSuweC7fICSk0AAR9bIzsS1qHqO7MsqY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(23010399003)(376014)(56012099006)(10067099003)(3023799007)(22082099003)(18002099003)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BjAi/0+Xeioqg4GwOU4SOwy9rTrUVHhHlCq4ZoqItGpOJFttj7rk8nXerhVp?= =?us-ascii?Q?pQ5yCgEEfb2Qvot2lAZgF39i8DTqI8PpagHrTm3yADRLfwqErdVVesEQDEa8?= =?us-ascii?Q?6vQZSSgnEfpso/+zYtzMCpsH3outchfe8F1ZPXNV2nWNYnU3uMk1/BTVumWo?= =?us-ascii?Q?dZWIKXEGZ6MreulYdmwIicFoiWkZcDBqVPgYYHeVBxNPaWB3pD34owjjNjMF?= =?us-ascii?Q?3wxKo1vJzILljlaI5acYdaADnQ6LY1YNYa85R34EIDdoukKG7PYkJcwDEcgD?= =?us-ascii?Q?rfbYLcHRAkM7W5IHl0jwNeUyJE4p5vwp/owhPxMeygsMA4qHiSb6waE1MZXk?= =?us-ascii?Q?0z0htlMiCJBDF+w54o2jBEzNwOohnCYNi+6clUK9HAekJEnPzTqs+Dy5fPle?= =?us-ascii?Q?BjZZu18whaSjMkxDJGYbp2ojqJRBr/1KJrHdUQryN9E1KbMUFvwkRJ1R/I0f?= =?us-ascii?Q?pVnst648Zi4Iqv5i5/Yxspl+C6QQl8bCC8qisWaduS0IHVZsPV59RTMsDq2Z?= =?us-ascii?Q?HR48lVcb+jduQEMgAJ4WKCLnVWrAgkguFF/mIoNn6GsxxouaA2DaXBQxNJGV?= =?us-ascii?Q?2oe18t2PzE1R+h+3WqYDSaQZRcQQUF3xy846lVryWwQw0NZDMF/x+xfyCYr4?= =?us-ascii?Q?bU+0oXxqBQsVFHabtkYYdWrM/VuwhPq1KXrIvbspW07thHMKEHPAm9vSPwTX?= =?us-ascii?Q?ssGDcxky6fZ+/OeWqnTNsh2uawj1h+ee+N4A3XA7LU672XXm/sdyO4oAuzwb?= =?us-ascii?Q?CkugJgnnpw8smiZ0xS31EmJgVzjPXMMcrEomglFsXaFiK9cUM0p4REL99tYg?= =?us-ascii?Q?IhCoZgwse0gESmgieu3zt8dxZxlnIam3r9lhkUMWBH3fiBKDSw5h6odAlJY6?= =?us-ascii?Q?tKLID8tSRlEbumEmCBPiHmL39jOjh+By5sCsfroa5O3NXbA8tUoSTCjoS9no?= =?us-ascii?Q?30tUtNSyWDKmbdM2mq+B13sU+roMf45ljarePk2V1uPI171PnqTep6OU6vOd?= =?us-ascii?Q?3pU6emlDTUDnbQ8nHrn6i7CQBR5yULV0VbHXLfUvEjc0iuSoVZ8XWbFrEd7y?= =?us-ascii?Q?4Q2aKQPxr5hPQln1CWgadTm01N1G6xfweHseegje7A3z8vCvkeDHytSn4lb5?= =?us-ascii?Q?vM98Re/fztwANG4kuYVcQ7xIuNX9TAQ3z8/LiVvnqCKyfrs82O8UqXwp2Ayu?= =?us-ascii?Q?shcsgmcCeD1P1dXqIDDpnekI4/z72mxdmD2X3rqdhTOXjwzSd9MBbWRJav3e?= =?us-ascii?Q?btapMJUfVxRav6l1atzm06C9fPGGp8PP3ODT4A/Seebn2NdT04iwZC1y1zoQ?= =?us-ascii?Q?wna9VdZknDKGbtyN1/5wndf1aJJ2F1l6zf71ZcUYwl1nBAPQg3xGeN+FwZIh?= =?us-ascii?Q?ghcRxL9jX1TS14QR+GPjCirroP5I/evQF7eXzDldTzLKpPCE/jOvyLNUVWYa?= =?us-ascii?Q?fIKRtfrismMYW7EovZPZ/6KZ7zSl0sLRhXJQjOgNPnQ2JgI4dQfA8jVedQHI?= =?us-ascii?Q?KjuUXxiLSVQztC3k4l6HNpGyVz/dS/WvfMnFS5riMtdkWC2bLfQsPaB/ZzNC?= =?us-ascii?Q?pmt6bBgmU/FJh7UMwLZZ6YNEwJgDmDdqlTbGnZKzrMZw2ufo1zWdaOGu0HJc?= =?us-ascii?Q?T+C/JkX0rZdq7VCUBom/lqE1Icb7NsgvM9Q5kKM5eAPEEqH/jqwck0DOvDlr?= =?us-ascii?Q?EmCulXMPQhzy2my2KgSs3KPeo7kY01l2sjdQ8AUdxQjXlYaE2sTQo42hhkcC?= =?us-ascii?Q?noyap3h/yFD2Tjs7DCIRZ0ehXd41KZESD00DGoRutl7JsYb/eOxq?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa14e99-4e1f-4708-03de-08defdfdc704 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2026 14:25:54.3681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e8t2qK75BXkF2mSrWSOV+In3PQPwPt18Q5mwtfr0L6p4gKZlGODTB+4ES6lt1OjKT3OgdynjbW5gFe7YA8o2E73/l7ZJP7qjbLgARDy9tzP/5GFWnEO3z7gofJVuqOm1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8462 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260819_072559_860997_6B82AC07 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 19, 2026 at 06:05:41PM +0900, Zhipeng.wang_1@oss.nxp.com wrote: > From: Zhipeng Wang > > probe() maps the parent output interrupts with irq_of_parse_and_map(), > but remove() only unchains the handlers and never disposes of those > mappings, leaking them on unbind. The child mappings handed out by the > domain are freed by their consumers and, together with the domain, are > now torn down by devres, so remove() only has to dispose of the parent > mappings it created itself. > > Dispose of the parent mappings alongside the chained-handler teardown. > > Fixes: 0136afa08967 ("irqchip: Add driver for imx-irqsteer controller") > Signed-off-by: Zhipeng Wang > --- Reviewed-by: Frank Li > drivers/irqchip/irq-imx-irqsteer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c > index 359b8ebc1bae..320082d3a632 100644 > --- a/drivers/irqchip/irq-imx-irqsteer.c > +++ b/drivers/irqchip/irq-imx-irqsteer.c > @@ -283,6 +283,7 @@ static void imx_irqsteer_remove(struct platform_device *pdev) > > irq_set_chained_handler_and_data(irqsteer_data->irq[i], > NULL, NULL); > + irq_dispose_mapping(irqsteer_data->irq[i]); > } > > clk_disable_unprepare(irqsteer_data->ipg_clk); > -- > 2.34.1 > >