From: Breno Leitao <leitao@debian.org>
To: KobaK <kobak@nvidia.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Fenghua Yu <fenghuay@nvidia.com>, Tushar Dave <tdave@nvidia.com>,
Kai-Heng Feng <kaihengf@nvidia.com>,
rupakr@nvidia.com, mohammedk@nvidia.com
Subject: Re: [RFC PATCH 1/3] arm64: add CPU prefetch and cache modulation sysfs interface
Date: Wed, 19 Aug 2026 07:43:28 -0700 [thread overview]
Message-ID: <aoXAdSY_EyPlOOnK@gmail.com> (raw)
In-Reply-To: <20260817022335.3-2-kobak@nvidia.com>
On Mon, Aug 17, 2026 at 10:23:33AM +0800, KobaK wrote:
> +static void cpumod_attr_read_remote(void *info)
> +{
> + struct cpumod_attr_call *call = info;
> + u64 *value = cpumod_attr_value_ptr(call->subsys, call->attr);
> +
> + *value = cpumod_attr_read_reg(call->attr);
> +}
Why do you need value in this case? Also, isn't cpumod_attr_read_reg()
anmd returning to a variable that is never read?
next prev parent reply other threads:[~2026-08-19 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 2:23 [RFC PATCH 0/3] arm64: expose CPU prefetch and cache modulation controls KobaK
2026-08-17 2:23 ` [RFC PATCH 1/3] arm64: add CPU prefetch and cache modulation sysfs interface KobaK
2026-08-17 22:07 ` Rob Herring
2026-08-19 14:43 ` Breno Leitao [this message]
2026-08-19 14:57 ` Breno Leitao
2026-08-17 2:23 ` [RFC PATCH 2/3] Documentation/arch/arm64: document arm_cpumod KobaK
2026-08-17 22:03 ` Rob Herring
2026-08-17 2:23 ` [RFC PATCH 3/3] selftests: arm64: add arm_cpumod kselftest KobaK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoXAdSY_EyPlOOnK@gmail.com \
--to=leitao@debian.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=fenghuay@nvidia.com \
--cc=kaihengf@nvidia.com \
--cc=kobak@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mohammedk@nvidia.com \
--cc=rupakr@nvidia.com \
--cc=skhan@linuxfoundation.org \
--cc=tdave@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox