From: Itaru Kitayama <itaru.kitayama@fujitsu.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Anup Patel <anup@brainfault.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Fuad Tabba <fuad.tabba@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Atish Patra <atish.patra@linux.dev>,
Alexandre Ghiti <alex@ghiti.fr>,
David Hildenbrand <david@kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, loongarch@lists.linux.dev,
kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Ritesh Harjani <ritesh.list@gmail.com>
Subject: Re: [PATCH 00/20] KVM: selftests: PPC pre-enabling
Date: Thu, 27 Aug 2026 17:07:40 +0900 [thread overview]
Message-ID: <ao_wTAq6U2bvWzgu@sm-arm-grace07> (raw)
In-Reply-To: <20260826230511.972824-1-seanjc@google.com>
On Wed, Aug 26, 2026 at 04:04:51PM -0700, Sean Christopherson wrote:
> This is a big pile of cleanups and refactoring to prepare for PPC support in
> KVM selftests. PPC has paging modes that require multi-page page tables, and
> those page tables need to be naturally aligned. The original proposal was to
> plumb in an @align param to the page allocators[*], but I didn't love the idea
> of adding another rarely used param to the allocators.
>
> Reworking the APIs to take a region type requires a fair bit of churn, and was
> more painful than expected as I didn't realize just how many one-off tests did
> weird things, but overall I think it's worth it? If only to keep cutting down
> on the use of magic memslot numbers in tests.
>
> This needs explicit testing on s390. I tested on arm64 and x86, and given the
> number of failures I had to wade through, I wouldn't be at all suprised if I
> broke something subtle on s390 as well.
>
> I'm less concerned about RISC-V and LoongArch as they don't have any custom
> tests that are affected (which is where I got burned).
I ran kvm_page_table_test with this series applied on Grace CPUs.
Passes across all the arm64 guest modes supported.
Tested-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
>
> [*] https://lore.kernel.org/all/df86b5ccdbdafc3509d9538bd5e6796737bab2db.1781093720.git.ritesh.list@gmail.com
>
> Nicholas Piggin (1):
> KVM: selftests: Use goto instead of do-while to retry finding unused
> physical pages
>
> Sean Christopherson (19):
> KVM: selftests: Use MEM_REGION_PT memslot instead of '0' for s390
> regions/segments
> KVM: selftests: Bump the minimum GPA for page tables to 0x200000
> KVM: selftests: Use vm_alloc_page_table() to allocate LoongArch page
> tables
> KVM: selftests: Rename "num" param to "nr_pages" for physical page
> allocators
> KVM: selftests: Extend page allocator to support naturally aligned
> allocations
> KVM: selftests: Make the single-page allocator APIs static inline
> KVM: selftests: Use the innermost page allocator API in the memslot
> perf test
> KVM: selftests: Use the innermost page allocator API in s390's IRQ
> routing test
> KVM: selftests: Add a wrapper API to allocate multiple page table
> pages
> KVM: selftests: Initialize vm->memslots[] with invalid memslots during
> creation
> KVM: selftests: Add APIs to override memory region types with custom
> memslots
> KVM: selftests: Add TEST_EXTRA memory region type for "special"
> memslots
> KVM: selftests: Use TEST_EXTRA region in arm64's vGIC LPI stress test
> KVM: selftests: Use TEST_EXTRA region in x86's smaller MAXPHYADDR test
> KVM: selftests: Use TEST_EXTRA region in set memory region test
> KVM: selftests: Take the memory region type, not memslot, in page
> allocators
> KVM: selftests: Use TEST_ASSERT(), not assert(), in
> vm_get_mem_region()
> KVM: selftests: Automatically pick min_gpa for allocations based on
> region type
> KVM: selftests: Add arch hook to force page tables to be naturally
> aligned
>
> .../selftests/kvm/arm64/page_fault_test.c | 18 ++-
> .../selftests/kvm/arm64/vgic_lpi_stress.c | 19 ++-
> .../testing/selftests/kvm/include/kvm_util.h | 106 +++++++++++++--
> tools/testing/selftests/kvm/include/x86/smm.h | 2 +-
> .../selftests/kvm/lib/arm64/processor.c | 4 +-
> tools/testing/selftests/kvm/lib/kvm_util.c | 127 +++++++++++-------
> .../selftests/kvm/lib/loongarch/processor.c | 5 +-
> .../selftests/kvm/lib/riscv/processor.c | 4 +-
> .../selftests/kvm/lib/s390/processor.c | 7 +-
> .../testing/selftests/kvm/lib/x86/processor.c | 15 ++-
> .../testing/selftests/kvm/memslot_perf_test.c | 3 +-
> tools/testing/selftests/kvm/s390/cmma_test.c | 19 +--
> .../testing/selftests/kvm/s390/irq_routing.c | 2 +-
> .../selftests/kvm/set_memory_region_test.c | 8 +-
> .../x86/smaller_maxphyaddr_emulation_test.c | 9 +-
> 15 files changed, 219 insertions(+), 129 deletions(-)
>
>
> base-commit: 76671054f9a1ff6abb976583cd8da37650acdc97
> --
> 2.55.0.887.g758fc8c411-goog
>
prev parent reply other threads:[~2026-08-27 8:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 23:04 [PATCH 00/20] KVM: selftests: PPC pre-enabling Sean Christopherson
2026-08-26 23:04 ` [PATCH 01/20] KVM: selftests: Use MEM_REGION_PT memslot instead of '0' for s390 regions/segments Sean Christopherson
2026-08-26 23:04 ` [PATCH 02/20] KVM: selftests: Bump the minimum GPA for page tables to 0x200000 Sean Christopherson
2026-08-26 23:04 ` [PATCH 03/20] KVM: selftests: Use vm_alloc_page_table() to allocate LoongArch page tables Sean Christopherson
2026-08-27 6:43 ` Bibo Mao
2026-08-26 23:04 ` [PATCH 04/20] KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators Sean Christopherson
2026-08-26 23:04 ` [PATCH 05/20] KVM: selftests: Use goto instead of do-while to retry finding unused physical pages Sean Christopherson
2026-08-26 23:04 ` [PATCH 06/20] KVM: selftests: Extend page allocator to support naturally aligned allocations Sean Christopherson
2026-08-26 23:04 ` [PATCH 07/20] KVM: selftests: Make the single-page allocator APIs static inline Sean Christopherson
2026-08-26 23:04 ` [PATCH 08/20] KVM: selftests: Use the innermost page allocator API in the memslot perf test Sean Christopherson
2026-08-26 23:05 ` [PATCH 09/20] KVM: selftests: Use the innermost page allocator API in s390's IRQ routing test Sean Christopherson
2026-08-26 23:05 ` [PATCH 10/20] KVM: selftests: Add a wrapper API to allocate multiple page table pages Sean Christopherson
2026-08-27 5:27 ` Itaru Kitayama
2026-08-26 23:05 ` [PATCH 11/20] KVM: selftests: Initialize vm->memslots[] with invalid memslots during creation Sean Christopherson
2026-08-26 23:05 ` [PATCH 12/20] KVM: selftests: Add APIs to override memory region types with custom memslots Sean Christopherson
2026-08-26 23:05 ` [PATCH 13/20] KVM: selftests: Add TEST_EXTRA memory region type for "special" memslots Sean Christopherson
2026-08-27 4:37 ` Itaru Kitayama
2026-08-26 23:05 ` [PATCH 14/20] KVM: selftests: Use TEST_EXTRA region in arm64's vGIC LPI stress test Sean Christopherson
2026-08-26 23:05 ` [PATCH 15/20] KVM: selftests: Use TEST_EXTRA region in x86's smaller MAXPHYADDR test Sean Christopherson
2026-08-26 23:05 ` [PATCH 16/20] KVM: selftests: Use TEST_EXTRA region in set memory region test Sean Christopherson
2026-08-26 23:05 ` [PATCH 17/20] KVM: selftests: Take the memory region type, not memslot, in page allocators Sean Christopherson
2026-08-26 23:05 ` [PATCH 18/20] KVM: selftests: Use TEST_ASSERT(), not assert(), in vm_get_mem_region() Sean Christopherson
2026-08-26 23:05 ` [PATCH 19/20] KVM: selftests: Automatically pick min_gpa for allocations based on region type Sean Christopherson
2026-08-26 23:05 ` [PATCH 20/20] KVM: selftests: Add arch hook to force page tables to be naturally aligned Sean Christopherson
2026-08-27 8:07 ` Itaru Kitayama [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao_wTAq6U2bvWzgu@sm-arm-grace07 \
--to=itaru.kitayama@fujitsu.com \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=fuad.tabba@linux.dev \
--cc=imbrenda@linux.ibm.com \
--cc=joey.gouly@arm.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=npiggin@gmail.com \
--cc=oupton@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=pjw@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=seanjc@google.com \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox