From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Li Jun <lijun01@kylinos.cn>
Cc: sudeep.holla@kernel.org, cristian.marussi@arm.com,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] firmware: arm_scmi: pm: use DEFINE_SIMPLE_DEV_PM_OPS for pm struct
Date: Thu, 20 Aug 2026 07:10:20 +0200 [thread overview]
Message-ID: <aoaLBNkkSynoGH5M@monoceros> (raw)
In-Reply-To: <20260820021718.2454014-1-lijun01@kylinos.cn>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Thu, Aug 20, 2026 at 10:17:18AM +0800, Li Jun wrote:
> use DEFINE_SIMPLE_DEV_PM_OPS for scmi_dev_pm_ops,and add the value of
> .freeze .thaw .poweroff .restore.if these address are null, may cause
> error in s4.
>
> Change:
> -Replace SIMPLE_DEV_PM_OPS() in v1 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
The things I wrote at
https://lore.kernel.org/all/aoaFlNcXC8zfS0j5@monoceros/ mostly apply
here, too.
TL;DR: Wrong placement of inter-revision changelog, missing
pm_sleep_ptr(), and maybe most prominently the request for patience to
start with a single patch and learn from the feedback for later patches.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-08-20 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 2:17 [PATCH v2] firmware: arm_scmi: pm: use DEFINE_SIMPLE_DEV_PM_OPS for pm struct Li Jun
2026-08-20 5:10 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoaLBNkkSynoGH5M@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=lijun01@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox