Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	 Mark Rutland <mark.rutland@arm.com>,
	David Hildenbrand <david@kernel.org>,
	 Ryan Roberts <ryan.roberts@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: mm: Walk page tables with interrupts disabled in show_pte()
Date: Fri, 28 Aug 2026 05:43:45 +0200	[thread overview]
Message-ID: <apEDnrEbpvXq-mTe@gmail.com> (raw)
In-Reply-To: <apBKADD1xiGWzHCB@willie-the-truck>

On Thu, Aug 27, 2026 at 03:30:24PM +0100, Will Deacon wrote:
> > @@ -151,6 +152,8 @@ static void show_pte(unsigned long addr)
> >  		return;
> >  	}
> >  
> > +	guard(irqsave)();
> > +
> >  	pr_alert("%s pgtable: %luk pages, %llu-bit VAs, pgdp=%016lx\n",
> >  		 mm == &init_mm ? "swapper" : "user", PAGE_SIZE / SZ_1K,
> >  		 vabits_actual, mm_to_pgd_phys(mm));
> 
> Curious, but why did you add the guard before the print?

Good point. No need to cover the print, I'll move it below in v2.

Thanks,
Karl


      reply	other threads:[~2026-08-28  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 21:13 [PATCH] arm64: mm: Walk page tables with interrupts disabled in show_pte() Karl Mehltretter
2026-08-27 14:30 ` Will Deacon
2026-08-28  3:43   ` Karl Mehltretter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apEDnrEbpvXq-mTe@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=david@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ryan.roberts@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox