From: Mostafa Saleh <smostafa@google.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, will@kernel.org,
robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca,
nicolinc@nvidia.com, praan@google.com
Subject: Re: [PATCH 5/7] iommu/arm-smmu-v3-test: Add missing error checks for inv array
Date: Tue, 1 Sep 2026 08:51:34 +0000 [thread overview]
Message-ID: <apaSFtf2xe-qbKbg@google.com> (raw)
In-Reply-To: <178792724271.3808739.15472225478426952013.b4-review@b4>
On Fri, Aug 28, 2026 at 11:27:22AM -0300, Jason Gunthorpe wrote:
> > arm_smmu_invs_merge() and arm_smmu_invs_alloc() can return NULL or
> > errors which are checked by the driver but not the test.
> >
> > Add KUNIT_ASSERT_NOT_ERR_OR_NULL() after calling them to fail the
> > test instead of accessing NULL or ERR pointers.
>
> I've generally had the opinion that if kunit tests hit bugs I don't
> actually care what happens next so long as the bug is evident.. Many
> tests can't clean up when they get longjump'd out like this too.
I tend to agree as that's how I use kunit also, but I'd be extra
careful around crashing the kernel from kunit as it can be triggered
from userspace.
Thanks,
Mostafa
>
> So, IDK, it is fine but I also think this is in a category that maybe
> sashiko prompts should address instead somehow.
>
> --
> Jason
next prev parent reply other threads:[~2026-09-01 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 12:53 [PATCH 0/7] iommu/arm-smmu-v3: Fixes reported by Sashiko Mostafa Saleh
2026-08-28 12:53 ` [PATCH 1/7] iommu/arm-smmu-v3: Ensure L2 tables are visible before L1 ptrs Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:03 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 2/7] iommu/arm-smmu-v3: Prevent rbtree corruption from duplicate streams Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 15:51 ` Nicolin Chen
2026-09-01 8:44 ` Mostafa Saleh
2026-08-28 12:53 ` [PATCH 3/7] iommu/arm-smmu-v3-iommufd: Fix error path in arm_vsmmu_cache_invalidate() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-09-01 8:47 ` Mostafa Saleh
2026-08-28 12:53 ` [PATCH 4/7] iommu/arm-smmu-v3-test: Fix arm_smmu_v3_test_debug_print_used_bits() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:12 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 5/7] iommu/arm-smmu-v3-test: Add missing error checks for inv array Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-09-01 8:51 ` Mostafa Saleh [this message]
2026-08-28 12:53 ` [PATCH 6/7] iommu/arm-smmu-v3-test: Fix OOB in arm_smmu_v3_invs_test_verify() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:14 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 7/7] iommu/arm-smmu-v3-test: Fix UBSAN error Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:14 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apaSFtf2xe-qbKbg@google.com \
--to=smostafa@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox