From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79E2BC624D6 for ; Thu, 3 Sep 2026 12:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7MA2mEDxP1HoCy4ZdvP/VvBJGdm4FhYat4tl3ZvylF8=; b=D2Y4DT6y/pKpXQIUUXt1Ub1mqi gxl/BxjKuv6AJAeex/24vRi3fCkR8CJbri+mIOigw8Uoqre+3XG20Dkt3z3u3zzMnmUAxDiglwzO/ JN8No9t/jEB9nN9zDSFQ7PQ3C1e7DWD7M8hDLXhrHzscITw44fICHcr2k3zwDXU89P/guo0hBzT9O pqFqZMDY9XveGDBKCVICBqTTQAs10nir+1Gv0Uxamxzl/igWGQwviUkWlT65tMoBqwUesOBmlRKcD 9apAcC1bdLuY2gu227LoYXpayjPmqyZ85aSSTSwZbrsFp1WX8pbVgrREPb+UW02+ehNgm5mFUbUlc JVJWrdBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x26wS-0000000HM7i-49CX; Thu, 03 Sep 2026 12:53:20 +0000 Received: from mgamail.intel.com ([198.175.65.13]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x26wP-0000000HM7E-1cO6 for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2026 12:53:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788439998; x=1819975998; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tG43r3ybKL5uUT1O97RFbvlWYx+uuXHDv+04GQeYfAI=; b=cGemzVTjhDdm/eKK4bNao3ZNAGnj6P2DnGgCd509ZXfEg/zhh7expQDY aesXNjBG3S1Q0VKb/uRKUdcZxOPi3XRDMvB4ZVbikia/zSiZDklNICZ1E 3OGMTrrwZvEPO3KAu+sD8OWGP50UitVu4AfEwJln9ADF515UkGZs3VDUv SQGbzQH6Mkdz0O8sIsoV5oDZRI6zrzOQe0FVr6kayPylqTRYBhl8zPcT+ tgUVEozUXzwtdLOxHDDImYtsElbYA0+zMmZWVgP+TMgTbHsd9I6BvHJ9V 2fKrrPGK1bFNt6fTxJVxHOS74AS9aztv+85tC20gBsGXNZOMxWr1ewQC0 Q==; X-CSE-ConnectionGUID: 1dPDaXS/RSG3hLIoEpUjkQ== X-CSE-MsgGUID: 75fzH3E7RdO2SRAw+1FwkA== X-IronPort-AV: E=McAfee;i="6800,10657,11894"; a="100079198" X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="100079198" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 05:53:17 -0700 X-CSE-ConnectionGUID: EG6UkGFQT6G/iLYPpVG6aQ== X-CSE-MsgGUID: Fv19EkL4QhedtceXVGp5ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="265372033" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.28]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 05:53:11 -0700 Date: Thu, 3 Sep 2026 15:53:08 +0300 From: Andy Shevchenko To: zl020895 Cc: longzhao , Arnd Bergmann , Krzysztof Kozlowski , Alexandre Belloni , soc , linux-arm-kernel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Catalin Marinas , Will Deacon , devicetree , linux-clk , linux-gpio , linux-serial , linux-kernel , Brian Masney , Lee Jones , mfd Subject: Re: Re: Re: [PATCH v5 10/12] serial: 8250: add Ambarella UART driver Message-ID: References: <20260818-cv75-v5-v5-0-7bbb12f0360f@ambarella.com> <20260818-cv75-v5-v5-10-7bbb12f0360f@ambarella.com> <162c0385.2c076.1a018b82fa7.Coremail.zl020895@163.com> <709278f9.9699.1a067207b4c.Coremail.zl020895@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <709278f9.9699.1a067207b4c.Coremail.zl020895@163.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260903_055317_501806_3E54DD94 X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2026 at 07:56:17PM +0800, zl020895 wrote: > > Thanks for the confirmation. > I will keep 8250_ambarella and update the commit message as you > suggested. No, I mean to go back to the version that modifies 8250_dw. > At 2026-09-03 19:40:54, "Andy Shevchenko" wrote: > >On Wed, Aug 19, 2026 at 02:31:59PM +0800, zl020895 wrote: > >> > >> Thanks for the review. > > > >> This is Ambarella 8250-compatible IP, not Synopsys DesignWare. We > >> first tried 8250_dw after Linus asked us to move to the 8250 library; > >> you then told us not to touch 8250_dw and to use 8250_ambarella > >> instead. That is what this patch is. > >> Background: > >> https://lore.kernel.org/r/CAD++jLm6HzEU1TM-c=Vtjv3FJEBecVP7TyxSgq_Q0zF-YwT6NA@mail.gmail.com/ > >> https://lore.kernel.org/linux-serial/an8KvvHWX0naH3Xw@ashevche-desk.local/ > >> https://lore.kernel.org/linux-serial/7E774305-3920-4BB7-BA46-E0772D6BED84@ambarella.com/ > >> I will also switch to uart_read_port_properties() and trim the > >> 8250_dw-derived boilerplate. > > > >Thanks for the register descriptions, it was helpful. After going through them > >it seems the v3 as you made it is good enough (sorry for going back and forth). > >What it needs is better commit message explaining that while it's not a Synopsys > >DW IP, it was made to be quite compatible with that (on register level) and hence > >no new driver is required, just a small quirk. -- With Best Regards, Andy Shevchenko