From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 722A3C982D0 for ; Sun, 20 Sep 2026 10:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AqS01F0fHUCNlMjJzLaTQZMMSglpdCcpPbBa80dW1pk=; b=cfNEexmZtf0c2ylgod6OCXhkMm 0nvuVEqdKiwgfZEeMaIlQhA/D3YvTvsv0CWnWFXXyJrP2k6NNtYb8g4Wt/kjvBHfeIN+5ouvgdX5M Vj5fLFw+zBos2Xq/jASE5PZpFJR98DpkhhzNkpD+RiJ2RMvdOKpmJ4BPWM44Wx2G2OZcAUzPsFifK Foa6MQslPugAlVohKYWqWArSPhH1oI3lwDgROEaNmiy9d0UMlLqcd7keq6DHzeVviYUpkzQlrFkOW req6Kqn3Uw12zC0H+vbOEmYPusOWyBy5+JtsKK02Z4zX+cL092eKJkfUOCZbezL192taI6ElIO8nq LcfkqLcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8EdL-0000000HFFu-2oU9; Sun, 20 Sep 2026 10:18:55 +0000 Received: from mail-wr2-x28.google.com ([2a00:1450:4864:30::28]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8EdI-0000000HFFW-1q8A for linux-arm-kernel@lists.infradead.org; Sun, 20 Sep 2026 10:18:54 +0000 Received: by mail-wr2-x28.google.com with SMTP id ffacd0b85a97d-485b1d2874aso1546346f8f.1 for ; Sun, 20 Sep 2026 03:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789899530; x=1790504330; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AqS01F0fHUCNlMjJzLaTQZMMSglpdCcpPbBa80dW1pk=; b=F9jLB7TrG82DPTkmpeNUnyz8ufhRXuOVjsF8oSiaO5ZQkbn0IpkkzDBm25Kl9Q9KRB RFQZY7/AqbufqbC4iEo9L35sT/WDoY0tOD822T9invsffAjzWZ0Pw0pqGtzNr/MikIvt NltbNBpgXENQ865u5ldib2F1LIL5Y3GGqnRc/YJVcbnQTlzelLTS3T/2EwG66WI6FIvy S8LNO7bsSgzhFEqPgEKfWSOshYxtd3ctjlOpMIozTVTQIbPMYdr3pCWLWmFuH/HuRR2B 6FSz3fOXhe1fz4vqdCFMuQt8iKGCPt92r8ajEZsVsyELW9TW6t3bBTYqwv/Z9YRzu1IU pELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789899530; x=1790504330; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AqS01F0fHUCNlMjJzLaTQZMMSglpdCcpPbBa80dW1pk=; b=xtk4WkOOQUsD1+26TBUK9NCAVznDkBrlwjItqYjRFA9DsV1RAo9R9sqdbhxU071dPx XjqFBWqTFtL0HVzlQ/EBzrqMgEzSglgzTkHDS0gyXyOAkt43SfOZ5G5T0MlTjZgdO7T8 69EILo8X/sMZwJnH3z/1vS0CDaXUFK0sF7mfN4piLqr/BRKh7B/zxasGqQLiiQzZYx0Q WfbifUGgk9wZ7CLTIyymHoPFL/m6FaKgcAsdeK+MWtV0n+bjn/LWLrLpEhuUyTZZxNip 1F7/Pfey7IU+a2GmiH3eoEEhtQVVDANuE4CBioeQkcyfXB/yswE1QqznxjklqV5uu/hw g4Ig== X-Forwarded-Encrypted: i=1; AKwUvBz9j3MExXbExeSkq+iePGbsmsXpiYh/PSg+IeULNc85IUbpJGkT4JHsPKk5hFDeAf0gVv7CdVDK/V+JFJDLR+48@lists.infradead.org X-Gm-Message-State: AFuF++n/1eS/9yeE4Joedmz2jULc8uQsVJxhXHy8FFSsZ/ZghDTede70 H2bWeqif3kVjGsrjF1rZUgv0aGXBa2fhm7WhJrJQtQeKstvrAEIW38z/PottzWZXYO4= X-Gm-Gg: AYBFou1SN1gF4hk2dEDJliSp4nwPK9XI1clmUxjMPTL+YVCaGW+vVVPbjnGfeJDqp8m Ci3S5sf/jmbxpFz9jVV/FondAc/CdHxno0veJlo6RgvrnGEC8Ma9NRFXZQpVi5/cRveW2NVRPcm 8zFMUnQs724Sq/AAnxIgFoLbl5PuslxQ3HPNBLV6SJSIIgoswbbrGDuxlLUOohZD8QBqqFUnyjH Y72ZoKuE+Okb9/fpTNoNbZZpZlnsiW81YT7eEokYHYKvsMt5OiMO/r1GmaZuiUmaTMnj2v8pbOi cuOafcU9lKSIIYjQ7QsvbcFs8D5BSD1ljO4ExaZBpvrHff1l+friZeluGHBFaWTa0fYzjvsZuCa GWwoTJtwqvxMJTUwz1cyY8ini7VpRzVrKaem8nZLw3RRl7ezfQbxkNIMsKedCBF+2hpeIPNiC0X 05KuTCJGN4pQuKF4jdNAwAW6Vsvb4xyu6ozAjy2jovYRMfssEI+os4iTZNaa6hl3+hdzZrT9RRY 78= X-Received: by 2002:a05:6000:310d:b0:487:27f9:82a with SMTP id ffacd0b85a97d-48727f90ab5mr5715729f8f.31.1789899529909; Sun, 20 Sep 2026 03:18:49 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4872459f446sm12973334f8f.35.2026.09.20.03.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 03:18:49 -0700 (PDT) Date: Sun, 20 Sep 2026 12:18:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: Hans de Goede , Bjorn Andersson , Cristian Marussi , Daniel Lezcano , Bjorn Andersson , Frank.Li@kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/2] module: add SCMI device table alias support Message-ID: References: <20260918092951.5656-1-johannes.goede@oss.qualcomm.com> <20260918092951.5656-2-johannes.goede@oss.qualcomm.com> <20260918-impetuous-daring-barnacle-1ea4d0@sudeepholla> <20260920-hippo-of-immense-assurance-50a5fd@sudeepholla> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="va5epoaani5qcgwk" Content-Disposition: inline In-Reply-To: <20260920-hippo-of-immense-assurance-50a5fd@sudeepholla> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260920_031852_508288_4DD97BBA X-CRM114-Status: GOOD ( 36.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --va5epoaani5qcgwk Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 1/2] module: add SCMI device table alias support MIME-Version: 1.0 On Sun, Sep 20, 2026 at 08:36:10AM +0100, Sudeep Holla wrote: > On Fri, Sep 18, 2026 at 10:39:46PM +0200, Uwe Kleine-K=F6nig wrote: > > On Fri, Sep 18, 2026 at 04:09:36PM +0200, Hans de Goede wrote: > > > Hi Sudeep, > > >=20 > > > On 18-Sep-26 15:32, Sudeep Holla wrote: > > >=20 > > > [...] > > >=20 > > > >> diff --git a/include/linux/device-id/scmi.h b/include/linux/device= -id/scmi.h > > > >> new file mode 100644 > > > >> index 000000000000..1b4ccfa9dcc5 > > > >> --- /dev/null > > > >> +++ b/include/linux/device-id/scmi.h > > > >> @@ -0,0 +1,17 @@ > > > >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > > >> +#ifndef LINUX_DEVICE_ID_SCMI_H > > > >> +#define LINUX_DEVICE_ID_SCMI_H > > > >> + > > > >> +#ifdef __KERNEL__ > > > >> +#include > > > >> +#endif > > > >> + > > > >> +#define SCMI_NAME_SIZE 32 > > > >> +#define SCMI_MODULE_PREFIX "scmi:" > > > >> + > > > >> +struct scmi_device_id { > > > >> + __u8 protocol_id; > > > >> + char name[SCMI_NAME_SIZE]; > > > >> +}; > > > >> + > > > >> +#endif /* ifndef LINUX_DEVICE_ID_SCMI_H */ > > > >=20 > > > > You need to include this above file in include/linux/mod_devicetabl= e.h > > > > to avoid duplication of its inclusion elsewhere. That's the pattern= followed > > > > I see. > > >=20 > > > That is what I did for v3, but Uwe, who is leading the splitting > > > of mod_devicetable.h from one large monster include to smaller > > > per subsystem/bus includes explicitly requested me to follow this > > > pattern, see: > > >=20 > > > https://lore.kernel.org/arm-scmi/aow2GFAfy84k-N2B@monoceros/ > > >=20 > > > [...] > > >=20 > > > >> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devic= etable-offsets.c > > > >> index b4178c42d08f..91ec3704ee2b 100644 > > > >> --- a/scripts/mod/devicetable-offsets.c > > > >> +++ b/scripts/mod/devicetable-offsets.c > > > >> @@ -1,5 +1,6 @@ > > > >> // SPDX-License-Identifier: GPL-2.0 > > > >> #define COMPILE_OFFSETS > > > >> +#include > > > >=20 > > > > Drop this for above mentioned reason. > > >=20 > > > This was explictly added at request of Uwe because the goal is to > > > get rid of mod_devicetable.h including all the device-id headers > > > in a big single catch-all include. This is done because currently > > > many files include mod_devicetable.h and then if any of the device-id > > > headers changes everything needs to be rebuild, making incremental > > > kernel builds much slower. > > >=20 > > > (and the same for the second include you point out) > >=20 > > FTR: That all sounds right. > >=20 > > Let's not add the the dependency mess that is mod_devicetable.h. > >=20 >=20 > I am confused. I am asking to align with what's done in > Commit ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers= ") > and you are disagreeing with that ? >=20 > I am not comfortable taking this patch unless there are other similar > examples that are agreed upon to break the pattern followed in the above > mentioned commit. >=20 > Uwe, please suggest. I didn't start removing stuff from mod_devicetable.h yet, as changes there are expensive (regarding build dependencies). So the plan is to stop drivers consuming mod_devicetable.h and then drop it. (Not sure this is sensible as new users come in faster than I can fight them, but I didn't give up yet.) So while adding new device_id structures to mod_devicetable.h is consistent with the existing practise, it still makes the situation worse, as every consumer of mod_devicetable.h then also depends on the new header for the new structure. That's why I think it's a good idea to deviate here, even if you're the first one doing so, to not worsen the already bad situation. If it helps you, I can propose a patch changing modpost to not use that catch-(nearly)-all header and use the needed linux/device-id/*.h instead. I put this on my list for tomorrow. Best regards Uwe --va5epoaani5qcgwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqvswQACgkQj4D7WH0S /k63ZQf/c1EcLMBypE8L0sxQ62078sgY69oGq5tDdBhnBZ+z4IPNuVUBpEsbf6CY hV/ZDy6EEWrIof70NynUSSft8Na4sKCCNoUAX0miGwkgyse7NXgu/+kfxKnYamH8 prDFe1BuWUgOnkVQz30liiPP2R54mXHS98TbV36hRU3VaKmT15gSgmQlaPwKiYud z/8blCaDCvt1oUpT1fLuAd6Ou3zvU9zLm/OpGl5sEMIHcJaTL+/+pJaJOyH34wg/ kfTaQUIXa9gYIwXzC+1IN7VLF1N0CVDKdSABYE1o+07SHdmM4GweLPPNshAaHSN6 N4WYHrSbicQ23mz2Vai55R+WDm/WKA== =3lua -----END PGP SIGNATURE----- --va5epoaani5qcgwk--