From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thorsten Blum <blum@kernel.org>
Cc: Harsha <harsha.harsha@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@amd.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: zynqmp-sha - fix NULL pointer dereference in init_tfm
Date: Fri, 18 Sep 2026 19:53:56 +1000 [thread overview]
Message-ID: <aq0KNOqblAfdG-NF@gondor.apana.org.au> (raw)
In-Reply-To: <20260908075339.396499-2-blum@kernel.org>
On Tue, Sep 08, 2026 at 09:53:40AM +0200, Thorsten Blum wrote:
> zynqmp_sha_init_tfm() checks crypto_shash_statesize(tfm_ctx->fbk_tfm)
> before assigning the fallback transform to it, which dereferences a NULL
> pointer since the transform context is zero-initialized. Use the local
> fallback_tfm pointer for the size check instead.
>
> Fixes: c1dd353d18e5 ("crypto: zynqmp-sha - Make descsize an algorithm attribute")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
> drivers/crypto/xilinx/zynqmp-sha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-09-18 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:53 [PATCH] crypto: zynqmp-sha - fix NULL pointer dereference in init_tfm Thorsten Blum
2026-09-18 9:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0KNOqblAfdG-NF@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=blum@kernel.org \
--cc=davem@davemloft.net \
--cc=harsha.harsha@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox