From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13456C88E4D for ; Fri, 11 Sep 2026 19:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zwltEYL3YNdlrAP6IKVR5tGeGFPOBBkOKK5RahqTZLY=; b=YL9s27BNWZFtE+Edq6PJjurmg1 ShGCZztA5PlqvCzVa7EtG4QGsEwn7WNMHHOX4s0cNiR3dSi11rTLK/4MFGCbda5pOjQcd3z49FWMv VEIss9lehWMd1HaPRr7N5Qm3UTEg4JCkqYZLtmuAZv8/ekHCVeBW6Mq9oYUTvoClT76F90qPa0RPQ X+qoyzyUCZyD734b+Zzx/REgieqteuNRWfLifO0h3BtpdkDRSdYst/bp52Nv13ubwbjK/ocB0/PZD l8I3uo/eW3EH+EK6Ct8MZw9+wBrZKWAtScVfnW8YLK3nrKbsBSrrDStxz7JI7tGCKAYjXIghQDbDz td89/kWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x56sx-0000000HYxa-34SC; Fri, 11 Sep 2026 19:26:07 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x56sw-0000000HYxK-1XPQ for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2026 19:26:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C2A8A417A3; Fri, 11 Sep 2026 19:26:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 388D01F000FF; Fri, 11 Sep 2026 19:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789154765; bh=zwltEYL3YNdlrAP6IKVR5tGeGFPOBBkOKK5RahqTZLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hr+PSViyFYrJMGSoit0iid0wlgstQnN2Aw0vdLi8Df0yH1Sl8uz+vL3v/h/dEAZ61 +LQH6UC8LgKeh54qenqYP3tPy1ZM5fhHgcTvRuNDJ/ScEVU8NAWUW60fiVd3tiyww8 LBoUw//JCyW4/WDCRaQ/Q0BNg8QPA1DP36bASCFBwHtDfxfroQaZmMgsPJmKTb4kwt vCCgjZkBA3/3+3xGP6NxDhe2Wo6tpFAuLNlZ4yytlrtOllS1I5gOtG4vtqXSfDB4co GF8IueQmiCrLa2kAmNZB75e8gMd/7MZ4UysauHMXCa/r4OYGI8h2rwGxGVTxZbJko6 HYjUzaEbvmfcw== Received: by traversing.sirena.org.uk (Postfix, from userid 1000) id 698F0DAC7A8; Fri, 11 Sep 2026 20:25:20 +0100 (BST) Date: Fri, 11 Sep 2026 20:25:20 +0100 From: Mark Brown To: "H. Nikolaus Schaller" Cc: Grond , Stefan Leichter , Grazvydas Ignotas , Tony Lindgren , Ethan Nelson-Moore , Jarkko Nikula , Sascha Hauer , Andreas Kemnade , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Aaro Koskinen , Kevin Hilman , Roger Quadros , Russell King , Daniel Thompson , Jingoo Han , Helge Deller , Jaroslav Kysela , Takashi Iwai , Sen Wang , Richard Fitzgerald , Arnd Bergmann , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Niranjan H Y , letux-kernel@openphoenux.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel@pyra-handheld.com, mfd@lists.linux.dev Subject: Re: [PATCH 08/16] ASoC: pcm1773-codec: write a driver for the PCM1773 chip from TI Message-ID: Mail-Followup-To: "H. Nikolaus Schaller" , Grond , Stefan Leichter , Grazvydas Ignotas , Tony Lindgren , Ethan Nelson-Moore , Jarkko Nikula , Sascha Hauer , Andreas Kemnade , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Aaro Koskinen , Kevin Hilman , Roger Quadros , Russell King , Daniel Thompson , Jingoo Han , Helge Deller , Jaroslav Kysela , Takashi Iwai , Sen Wang , Richard Fitzgerald , Arnd Bergmann , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Niranjan H Y , letux-kernel@openphoenux.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel@pyra-handheld.com, mfd@lists.linux.dev References: <7d8989813cbd750259dfdde2e1187082493279a0.1783749722.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8VWMi9X2XTocGtq+" Content-Disposition: inline In-Reply-To: <7d8989813cbd750259dfdde2e1187082493279a0.1783749722.git.hns@goldelico.com> X-Cookie: Orders subject to approval. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --8VWMi9X2XTocGtq+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 11, 2026 at 08:01:55AM +0200, H. Nikolaus Schaller wrote: > From: Grond >=20 > This chip is used in the OpenPandora. > +++ b/sound/soc/codecs/pcm1773.c > @@ -0,0 +1,149 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * pcm1773.c -- codec for the simple PCM1773 output codec from TI > + * > + * Shamelessly cobbled together from sound/soc/ti/omap3pandora.c and a f= ew > + * other codec drivers in sound/soc/codecs/ Please make the entire comment a C++ one so things look more intentional. > + .playback =3D { > + .stream_name =3D "PCM1773 IN", > + .channels_min =3D 2, > + .channels_max =3D 2, > + .rates =3D SNDRV_PCM_RATE_8000_48000, > + // [TODO] these really should be BE, per the data sheet but for > + // some reason the omap-mcbsp driver claims only to support LE. > + // investigate > + .formats =3D SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > + }, The format described here is the in memory format, not the wire format. > + ctx->regulator =3D devm_regulator_get(dev, "vcc"); > + if (IS_ERR(ctx->regulator)) { > + dev_warn(dev, "cannot get regulator 'vcc'"); > + ctx->regulator =3D NULL; > + } This is obviously broken. The driver should handle the error as a normal error, not just ignore it. --8VWMi9X2XTocGtq+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqkVZ8ACgkQJNaLcl1U h9ANxQf+NbBkZEJZSsd9ku1cZsPpGBfxhrqMreka7Y24CMLjnIcmPGw4KRrBOcWh rRYxpERw/bNXc0OPrSz0k4v7pUdnPmD7XL6q8smQFUqO0cAIZfkapEByQ5NNYXx/ vNSxUay1sNHex7SauqBichHdhyfPV1YSHJnPu9X2RPsbcvh60u0xvhnTlHIC8egT wIPtdj6srM7K+biEegoal8Cvy+5koZfoyRkIHQkSbMD1JFrFDkza3XbamNhPyIlv 5mP5Lwf0erONIrnizgA3LYZjHMUb6RmtEVoiu1azEwHRv87q42R9pOeiKDQiBhnH Gb+jZpZREv9HI5PwAFfeg4z9OuPDwQ== =K9b0 -----END PGP SIGNATURE----- --8VWMi9X2XTocGtq+--