From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 645EDC88E75 for ; Fri, 18 Sep 2026 07:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kM1dRFmDXeAoN/p5ctvzv5ZVRnmxbgQAJ3cL+XZ9LEo=; b=IC7yo6wWXR9K9C1puocfwP7/j1 Kgc28gLyEvPDbyEXd3gbZlFDL9vvDkiZ0qCYhQAkAC5n8zTVkpW5CLGWojHLJ3+0g0dRR5F/hBgES cb0OK0KDha1/wdKlhSJX7SghxpGbdWtoMizfIvrT57vHMzlHxN5cneyfd/Khx3Fw0BHBdvtRotYO9 +rGSTIRxow/iMIGizmd3p3lhs6znaVciOA/JNF1kSXJ6o1oSt8KnHVcwWO3hfisvJ2JPj0H5B1N3f BaZpQjE7PNM3ztzRTGewgtL3NWI6pfL2EP06MNwdObPFgCS9+ZYWmrElwksHuTkSi3gK3Nk29vfMQ et+c7TzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7T3U-0000000DhlK-4A79; Fri, 18 Sep 2026 07:30:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7T3T-0000000Dhkf-2VRq for linux-arm-kernel@bombadil.infradead.org; Fri, 18 Sep 2026 07:30:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kM1dRFmDXeAoN/p5ctvzv5ZVRnmxbgQAJ3cL+XZ9LEo=; b=E352pph6If8a9YIPKMbjqwMDbD zU+xbbghUzqaR9Z+DUotx1W90YZZlG+40oCz5XAptJNMBHDfanp1l03qoyNEdXGpUDgm9Sz5hgHk1 edIlMtiZH9Xh3RmLACeldgYsMIR7vXi6MNSr5boXk/fQ3fAHh/m6b2ksAwl6CgIUlJhfho8/vrsrm RtmwXs8f6VFtr8SFRngA9/cagcltSfrjFXKYj+TiMgUD1cwiWS0ICfveBFe+AoUimsv6HWONQ5W4Y mXLZIOZ/nKM6YtxV3cgfpztvi5PMx/WngN5l2kStWxu3vKczOJGj1TJNZ+cRkcLvy3glVDnMUIeVz xQWoWBrQ==; Received: from out-162.mta0.migadu.com ([2001:41d0:1004:224b::a2] helo=mta0.migadu.com) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x7T3P-00000009iE2-1OXv for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2026 07:30:42 +0000 X-Envelope-To: linux-arm-kernel@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=UhePvlO6Uju4KMSGgi0DFyyW4sOpnmjHBEaUsD91vSc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789716635; v=1; x=1790321435; b=ULNtSIa4m9Ewij1GnUkqGxU9aXQ2oILTA+9T2u7ixLXmqYR0nKCO44mGqYBlywtYYqe+h75F cwwwES+57lXO+C/ybgQiFLJQ5sAh/z90HQN0U4gkWvyg/gDIwUz7rPyp+n3UnwLXDcICr4PZZUq Gj0ULHhyxmZmM4k7ZqWmX/LQ= X-Envelope-To: linux-arm-kernel@lists.infradead.org Received: by mta10.migadu.com with ESMTPS id 37e6b37ee04b46ae; Fri, 18 Sep 2026 07:30:35 +0000 X-Mizu-Trace-ID: 37e6b37ee04b46ae X-Migadu-Flow: FLOW_OUT Date: Fri, 18 Sep 2026 15:30:28 +0800 From: Baoquan He To: Wandun Chen Cc: catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, robh@kernel.org, saravanak@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, m.szyprowski@samsung.com, mark.rutland@arm.com, kernel@xen0n.name, alex@ghiti.fr, hpa@zytor.com, ruirui.yang@linux.dev, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, iommu@lists.linux.dev Subject: Re: [PATCH v6 03/10] crash_core: fold duplicated memblock arch hooks into the weak default Message-ID: References: <20260902073116.802752-1-chenwandun1@gmail.com> <20260902073116.802752-4-chenwandun1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260902073116.802752-4-chenwandun1@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_083039_595911_EEA29F97 X-CRM114-Status: GOOD ( 22.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/02/26 at 03:31pm, Wandun Chen wrote: > From: Wandun Chen > > arm64, loongarch and riscv open-code the same memblock walk in > arch_get_system_nr_ranges() and arch_crash_populate_cmem(). Move it into > the __weak defaults in kernel/crash_core.c and delete the arch copies. > > No functional change. In one version, you also tried to remove these functions on x86, I could remember it wrong. Anyway, this looks good to me. Acked-by: Baoquan He > > Signed-off-by: Wandun Chen > Tested-by: Meijing Zhao > --- > arch/arm64/kernel/machine_kexec_file.c | 29 ---------------------- > arch/loongarch/kernel/machine_kexec_file.c | 27 -------------------- > arch/riscv/kernel/machine_kexec_file.c | 26 ------------------- > kernel/crash_core.c | 25 +++++++++++++++++-- > 4 files changed, 23 insertions(+), 84 deletions(-) > > diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c > index 854d872dfd0f..34d944d3f22f 100644 > --- a/arch/arm64/kernel/machine_kexec_file.c > +++ b/arch/arm64/kernel/machine_kexec_file.c > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -39,34 +38,6 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image) > return kexec_image_post_load_cleanup_default(image); > } > > -#ifdef CONFIG_CRASH_DUMP > -unsigned int arch_get_system_nr_ranges(void) > -{ > - unsigned int nr_ranges = 2 + crashk_cma_cnt; /* for exclusion of crashkernel region */ > - phys_addr_t start, end; > - u64 i; > - > - for_each_mem_range(i, &start, &end) > - nr_ranges++; > - > - return nr_ranges; > -} > - > -int arch_crash_populate_cmem(struct crash_mem *cmem) > -{ > - phys_addr_t start, end; > - u64 i; > - > - for_each_mem_range(i, &start, &end) { > - cmem->ranges[cmem->nr_ranges].start = start; > - cmem->ranges[cmem->nr_ranges].end = end - 1; > - cmem->nr_ranges++; > - } > - > - return 0; > -} > -#endif > - > /* > * Tries to add the initrd and DTB to the image. If it is not possible to find > * valid locations, this function will undo changes to the image and return non > diff --git a/arch/loongarch/kernel/machine_kexec_file.c b/arch/loongarch/kernel/machine_kexec_file.c > index 5412aa9f3568..481b8f906a56 100644 > --- a/arch/loongarch/kernel/machine_kexec_file.c > +++ b/arch/loongarch/kernel/machine_kexec_file.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -56,32 +55,6 @@ static void cmdline_add_initrd(struct kimage *image, unsigned long *cmdline_tmpl > } > > #ifdef CONFIG_CRASH_DUMP > -unsigned int arch_get_system_nr_ranges(void) > -{ > - int nr_ranges = 2; /* for exclusion of crashkernel region */ > - phys_addr_t start, end; > - uint64_t i; > - > - for_each_mem_range(i, &start, &end) > - nr_ranges++; > - > - return nr_ranges; > -} > - > -int arch_crash_populate_cmem(struct crash_mem *cmem) > -{ > - phys_addr_t start, end; > - uint64_t i; > - > - for_each_mem_range(i, &start, &end) { > - cmem->ranges[cmem->nr_ranges].start = start; > - cmem->ranges[cmem->nr_ranges].end = end - 1; > - cmem->nr_ranges++; > - } > - > - return 0; > -} > - > /* > * Add the "mem=size@start" command line parameter to command line, indicating the > * memory region the new kernel can use to boot into. > diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c > index 808e872f4063..fdc6695e8588 100644 > --- a/arch/riscv/kernel/machine_kexec_file.c > +++ b/arch/riscv/kernel/machine_kexec_file.c > @@ -37,32 +37,6 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image) > } > > #ifdef CONFIG_CRASH_DUMP > -unsigned int arch_get_system_nr_ranges(void) > -{ > - unsigned int nr_ranges = 2 + crashk_cma_cnt; /* For exclusion of crashkernel region */ > - u64 i; > - phys_addr_t start, end; > - > - for_each_mem_range(i, &start, &end) > - nr_ranges++; > - > - return nr_ranges; > -} > - > -int arch_crash_populate_cmem(struct crash_mem *cmem) > -{ > - u64 i; > - phys_addr_t start, end; > - > - for_each_mem_range(i, &start, &end) { > - cmem->ranges[cmem->nr_ranges].start = start; > - cmem->ranges[cmem->nr_ranges].end = end - 1; > - cmem->nr_ranges++; > - } > - > - return 0; > -} > - > static char *setup_kdump_cmdline(struct kimage *image, char *cmdline, > unsigned long cmdline_len) > { > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 2b36aa9fade0..77285ae3ce60 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -281,8 +281,29 @@ static struct crash_mem *alloc_cmem(unsigned int nr_ranges) > return cmem; > } > > -unsigned int __weak arch_get_system_nr_ranges(void) { return 0; } > -int __weak arch_crash_populate_cmem(struct crash_mem *cmem) { return -1; } > +unsigned int __weak arch_get_system_nr_ranges(void) > +{ > + unsigned int nr_ranges = 2 + crashk_cma_cnt; /* crashk_res + crashk_low_res, +CMA splits */ > + phys_addr_t start, end; > + u64 i; > + > + for_each_mem_range(i, &start, &end) > + nr_ranges++; > + return nr_ranges; > +} > + > +int __weak arch_crash_populate_cmem(struct crash_mem *cmem) > +{ > + phys_addr_t start, end; > + u64 i; > + > + for_each_mem_range(i, &start, &end) { > + cmem->ranges[cmem->nr_ranges].start = start; > + cmem->ranges[cmem->nr_ranges].end = end - 1; > + cmem->nr_ranges++; > + } > + return 0; > +} > int __weak arch_crash_exclude_ranges(struct crash_mem *cmem) { return 0; } > > int __weak arch_crash_exclude_mem_range(struct crash_mem **mem, > -- > 2.43.0 >