Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC

[Frank Li <Frank.li@oss.nxp.com>]

On Wed, Sep 30, 2026 at 09:29:34PM +0200, Marek Vasut wrote:
> On 9/30/26 8:57 PM, Frank Li wrote:
> > On Wed, Sep 30, 2026 at 07:44:13PM +0200, Francesco Dolcini wrote:
> > > On Tue, Sep 29, 2026 at 05:20:27PM +0200, Marek Vasut wrote:
> > > > On 9/29/26 4:45 PM, Frank Li wrote:
> > > >
> > > > Hello Frank,
> > > >
> > > > > > +	backlight_lvds: backlight-lvds {
> > > > > > +		compatible = "pwm-backlight";
> > > > > > +		pinctrl-names = "default";
> > > > > > +		pinctrl-0 = <&pinctrl_panel_backlight_lvds>;
> > > > > > +		brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
> > > > > > +		default-brightness-level = <7>;
> > > > > > +		enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
> > > > > > +		pwms = <&tpm3 3 5000000 0>;
> > > > > > +		/* Disabled by default, unless display board plugged in. */
> > > > > > +		status = "disabled";
> > > > > > +	};
> > > > >
> > > > > The both backlight is not used in this dts, can you remove it and
> > > > > add these when it real use.
> > > > It's the same thing we do on the other boards, so I would prefer to keep
> > > > this consistent:
> > >
> > > I agree with Marek, and I would not use the criteria about being used or
> > > not.
> >
> >
> > Others boards: some has dtso, which use it. And krzy have some concern for
> > similar case although he have not reply alex's answer.
> >
> > https://lore.kernel.org/imx/30599533-91de-41fd-9420-3f8693ec92ac@kernel.org/
> >
> > And it is most likely go through nexus connector node to support display
> > panel in future.
>
> I do not think nexus node will apply to this connector, no.
>
> > So I suggest remove it now and add it when need.
> Can we please go with consistency between these boards from one vendor ?

Yes, I am keeping consistency, then ask remove it. I applied alex's v2
version. I put v1 link to show krzy's concern.

https://lore.kernel.org/imx/20260319125013.2421621-3-alexander.stein@ew.tq-group.com/

Changes in v2:
* Changed commit message to imperative form
* Remove (currently unused) display and backlight nodes

Frnak

>
> Thank you.