Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	stable@vger.kernel.org, will@kernel.org
Subject: Re: [PATCH] arm64/fpsimd: signal: Forbid non-streaming SVE payload on SME-only systems
Date: Thu, 1 Oct 2026 15:42:24 +0100	[thread overview]
Message-ID: <ar5xUENHCvhAnUX3@J2N7QTR9R3.cambridge.arm.com> (raw)
In-Reply-To: <51351e42-60d1-417d-b61b-6011bfe5d2b5@sirena.org.uk>

On Thu, Oct 01, 2026 at 03:25:03PM +0100, Mark Brown wrote:
> On Thu, Oct 01, 2026 at 02:08:36PM +0100, Mark Rutland wrote:
> > @@ -443,19 +444,33 @@ static int restore_sve_fpsimd_context(struct user_ctxs *user)
> 
> >  	} else {
> >  		/*
> > -		 * A SME only system use SVE for streaming mode so can
> > -		 * have a SVE formatted context with a zero VL and no
> > -		 * payload data.
> > +		 * Non-streaming SVE state may be preserved without an SVE
> > +		 * payload, in which case all state is saved in the FPSIMD
> > +		 * context.
> > +		 *
> > +		 * On SME-only systems, non-streaming (FPSIMD-only) state is
> > +		 * always preserved without an SVE payload, and with VL==0. On
> > +		 * such systems, only accept non-streaming state without an SVE
> > +		 * payload.
> >  		 */
> > -		if (!system_supports_sve() && !system_supports_sme())
> > +		if (!system_supports_sve() && !fpsimd_only)
> >  			return -EINVAL;
> 
> This means that this function will now accept a FPSIMD only SVE context
> on systems with neither SVE nor SME, but that check was redundant since
> we already reject anything with SVE magic in parse_user_sigframe() on
> such systems and should never get here anyway.

Yes. The commit message explained that:

  As parse_user_sigframe() rejects SVE signal frames when neither SVE
  nor SME are supported, it isn't necessary for
  restore_sve_fpsimd_context() to handle the case where neither are
  supported.

> Reviewed-by: Mark Brown <broonie@kernel.org>

Thanks.

Mark.


  reply	other threads:[~2026-10-01 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 13:08 [PATCH] arm64/fpsimd: signal: Forbid non-streaming SVE payload on SME-only systems Mark Rutland
2026-10-01 14:25 ` Mark Brown
2026-10-01 14:42   ` Mark Rutland [this message]
2026-10-01 15:50 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar5xUENHCvhAnUX3@J2N7QTR9R3.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox