Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Hongjian Dai <daihongjian@kylinsec.com.cn>
Cc: codrin.ciubotariu@microchip.com, nicolas.ferre@microchip.com,
	 alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev,
	linux-i2c@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, me@cherr.cc
Subject: Re: [PATCH] i2c: at91: release DMA channels when probe defers
Date: Fri, 2 Oct 2026 00:36:31 +0200	[thread overview]
Message-ID: <ar7gTv9It4L_kuSM@zenone.zhora.eu> (raw)
In-Reply-To: <7D85C6CB6BF0A82E+20260929164340.41628-1-daihongjian@kylinsec.com.cn>

Hi Hongjian,

On Wed, Sep 30, 2026 at 12:43:40AM +0800, Hongjian Dai wrote:
> at91_twi_probe_master() can return -EPROBE_DEFER from
> at91_init_twi_recovery_info() after at91_twi_configure_dma() has already
> claimed the tx/rx DMA channels. at91_twi_probe() then returns without
> releasing them, and since dma_request_chan() is not devres-managed the
> channels leak on every deferred probe attempt.
> 
> Release the channels before deferring the probe.
> 
> Fixes: f7eeb1af8537 ("i2c: at91: release DMA channels on remove and probe error")
> Assisted-by: LLM
> Signed-off-by: Hongjian Dai <daihongjian@kylinsec.com.cn>

pushed to i2c/i2c-fixes.

Thanks,
Andi


      reply	other threads:[~2026-10-01 22:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 16:43 [PATCH] i2c: at91: release DMA channels when probe defers Hongjian Dai
2026-10-01 22:36 ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar7gTv9It4L_kuSM@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=daihongjian@kylinsec.com.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@cherr.cc \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox