From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40FA7C982ED for ; Mon, 21 Sep 2026 18:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YBNtvOgSHiOekCG7M9KpnxhG+lcqfmIAnCty8njQVrQ=; b=M4DcCyXmXwa70z2Hop0f7Oyxi0 Q6eMMTcjP3GpcK7dYUhIJy5hDZi58PJAY7e4rQAUUAepNEQVnjssu+RRmKCaaFBpKXzupHuv6ItDs iQajRBsb2dH1Of76DUAmyH+T9MdVLWFDgeZGrwX2JTIsgG+GesodxkTqEWzESr5TwRrPQJdpAqL2A nxZQhRiNNAiiyy71eVEQ4CA3z0+kYxYY2fp1Io8ph+ocqPrv19xH6fO7yJDJE9VA21oIxAN0e+MIP crOpGJ09SHpsQNWDA/7q8Z6u3Bu9OZ7SFpab11QSHV50sHfU3gYGo/edAH91fsKbtihdxFXsQK79/ 45Ikw8jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8its-000000038uH-1eNa; Mon, 21 Sep 2026 18:38:00 +0000 Received: from mail-westcentralusazon11010037.outbound.protection.outlook.com ([40.93.198.37] helo=CY7PR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8itp-000000038ti-3d5E for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2026 18:37:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KxttydJnz5gztRzgX8CAnAR8/9CLbRcCQJjCy6NLYYbs8ZRA9sns65vaRkktMf+yez3HhrtE2EmuopUae1gHdFXPvaChsC/YxXCf5K51Ct37Q29mUa0Gy/DKiPAVcVppin0bsRaASy8zJZFvWBermdHJtD1RbT/OZUH/mqgKVm4awSYSua88QY1NM8QYp0/BUdHubtXk/ZIUhKWNL173a2kzLIAxEJ+5FJhMfRQxYTV5rL4hK2r+d+03zCOM0YnhG3S9AS4BQ9k5D5cHoFJ7+Kb0RswHx+60RhzpVoo26FNcWfCKQ9oB4R9sL5O02V+/a1EU/Aj2ScrudGubID1cjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBNtvOgSHiOekCG7M9KpnxhG+lcqfmIAnCty8njQVrQ=; b=OvlGABg3jhT2m63nuFHZxBO7erCMpQWCfYgOrwYGxYsoB7+TE198zrECSvLJS+7JZBPIAwKC+mp8olQsZhR8M53ybNDMF3c4cfrP6eSdoG5RFRGkXgHUglgmAZoUF0GZnQn0OrQR4/feN0QMiJuCEQJd8CsoElXtNY2Gq+PMeRpIbXbtbAZdMv8atQtWGu6zOrZL6KQEqYbSKb+NUecAss60fRj4bqvE/dgD0wroG3SeamAsYcScuB3604Z1kKSDUZVyxOEm++MqUsJuLh8LHpKp16tT/KKXKrSHCL+bnB2e8xxyd7H9+Jpc3NrXPoKVEd0+5G6itWn8Qp1bIz5cww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=foxmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBNtvOgSHiOekCG7M9KpnxhG+lcqfmIAnCty8njQVrQ=; b=XEtnQw/H5b8EMWZQbwkYpr1dLEPxhCXzsCIkz397j65HhihygADSPkJh6Ln76OovZ9i6V3hKcKZg4Dds3Dg1oTSOceSHIlKEOWy4Ttp0ZfXyZxapdnfKgYK1NlHlNFIhUue06Wrv3lVrq01bouj/h93D1C1OzM/vEW9ljLDPLbBvnTmyCpn3ANchdrI7BIJYCkuGdWKhGOkDqdPKFy+Ist5kAG+ypbBGVniktDTwvaq6RuQzzS65axivipYZfZ8CtQ3Og2s7xVovMXvg3Ve07JhGJR3G9nB4+zHKsFUrFXQahEiTuiovIsYckiKsbGj48WqHqkL4zkyfj0tATkx15w== Received: from SJ0PR05CA0079.namprd05.prod.outlook.com (2603:10b6:a03:332::24) by DS5PPF8002542C7.namprd12.prod.outlook.com (2603:10b6:f:fc00::657) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.16; Mon, 21 Sep 2026 18:37:49 +0000 Received: from SJ1PEPF000037A8.namprd03.prod.outlook.com (2603:10b6:a03:332:cafe::9d) by SJ0PR05CA0079.outlook.office365.com (2603:10b6:a03:332::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.6 via Frontend Transport; Mon, 21 Sep 2026 18:37:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SJ1PEPF000037A8.mail.protection.outlook.com (10.167.244.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Mon, 21 Sep 2026 18:37:48 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 21 Sep 2026 11:37:26 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 21 Sep 2026 11:37:26 -0700 Received: from nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49 via Frontend Transport; Mon, 21 Sep 2026 11:37:25 -0700 Date: Mon, 21 Sep 2026 11:37:24 -0700 From: Nicolin Chen To: zhoumin CC: , , , , , , , Subject: Re: [PATCH] iommu/arm-smmu-v3: Skip unlinked duplicate stream nodes on removal Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037A8:EE_|DS5PPF8002542C7:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c5d47f6-f69a-4dd4-e1ef-08df180f6f92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|13003099007|22082099003|18002099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: DvDUfIdpiFvsAqtUQBnnNCrkwAfBFBSDal2qtiy6aIvzLTQdtujVrBbe7lZ9X8AcAFjh/4ZQYjptGq0YPRWNZ2/NhB3BUk+G60j6vuDfb2gY+vE8P0gvHmMYXwZUiYhmiSXe4IQTf6KvQLPlzCwNNJ0UDWmej6CxNhCBvma36wzwlT2gfEFUx4MqYOSVlc4iSQz7Rgl3Uehar7Jlgp4YhzV1YHwHYCGtlgDxg8YTcMDU07MoWYeX7DF5mJRmg3udJMQbVDztdC6HrMaAYuFF2hVDs0XpaeyFfUM0eB6dMrjCsx4jRRHTvOcZuFZoVq68XoxrSTHp5XyuGI16RkD93uPAwHr2U5f5uTjAOLCZg+MG9hdMMxYggJFL1MpRCFRtPathx6JiSnFoaTq29dE6kXTNuo8nnGA/hhgQw25ecknkIeeGhMHKvG66XYy0/i1qjXfc9pkC0i64zrRSoXTP95Kcl3R6XoTH6w3vehQ6KiXDvd/ZF1JiqzR3MCRAC7JjTIBS8kgGElH+bZShOU3oRLH4sU5w1NgeNlKmPvEjX7ROLvy33cnMCGwmt4GSl0Ic/A1iaNdnY+UMn0aXyedTf9RcykScoFlriyjAsLI1Ypsi3g8iOw1KBXx0TtqI5hFAQouV9cD37ENo8EcmKgwjM44MzlkMxD+2E3eolNln0cjpeYWD/yqok3xGqrBiVfEzru4EEzSIVA/9SGLHs6IUCw== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(13003099007)(22082099003)(18002099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DHkGo3g+bK8KF5YIzVrsU5MG+Jjrv5Mjcv8xQHtnNSy4efBO8jV8fs7CYkTRQcbtr0RVQwJ7gz3jn5+HL2Z2B0Qbxfjr4Y+bdYHkttSvT3LS5DGhE+xrmKvLkHkbIeRkApi7ix7uYjQLEEs1W5OPXWPVDw9Df+M2Qg0KyDwYlnJCFI4ebieZNBFnF4ocuVCwnqS805a0ohGhzyaUdiTlZ5HgZHvtvECULjd55JwAYceSOiwcAYG3fEGkm1m8YI8xyQbuUTRdEtDFt7Iq1a/G5/rVHfbcGVOCLHM/bnmePf5LpECh5uaWrFFp4lpYD2MtyUzXx7PIT/5aDQxZ02jqFjEpn1oOo8XGyMELJTZSNQHhE1/d1U+Ok3i2HC6bD3h1etVobQk0QEdqWKQOj3tJH2bSua2OWT8aNrX2ot/P8c844+nh8vxQx0+EV0fwpbYb X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 18:37:48.4806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c5d47f6-f69a-4dd4-e1ef-08df180f6f92 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037A8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPF8002542C7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260921_113757_905868_5FE2AD05 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 21, 2026 at 08:17:27PM +0800, zhoumin wrote: > A master's firmware stream ID list can contain duplicates, for example > for PCI devices behind an aliasing bridge. arm_smmu_insert_master() > accepts these IDs when the existing stream belongs to the same master, > but does not link the duplicate stream's rb_node into the SID tree. > > Both arm_smmu_remove_master() and the insertion error path nevertheless > call rb_erase() for every stream in their respective ranges. Erasing a > zero-initialized, unlinked node can clear the tree root, losing SID to > master mappings for other devices sharing the SMMU and leaving the tree > inconsistent for subsequent operations. > > Mark skipped duplicate nodes with RB_CLEAR_NODE() and skip them in both > removal paths. Set the marker after sorting the stream array, since it > contains the node's own address. Keep the stream array and num_streams > unchanged to preserve existing STE, invalidation and single-stream > feature checks. > > Fixes: b00d24997a11 ("iommu/arm-smmu-v3: Fix iommu_device_probe bug due to duplicated stream ids") I submitted a similar fix a while ago: https://lore.kernel.org/linux-iommu/9136477b9c737a50cecc38f2ee6704a01510169a.1783044582.git.nicolinc@nvidia.com/ I wonder if you really hit the issue or it's just a Sashiko finding? Nicolin