From: Mark Brown <broonie@kernel.org>
To: Ginger Li <ginger.jzllee@gmail.com>
Cc: claudiu.beznea@tuxon.dev, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mchp-spdiftx: Fix a deadlock with the interrupt handler
Date: Wed, 23 Sep 2026 15:36:54 +0200 [thread overview]
Message-ID: <arPV9kcq3hEv4F1v@sirena.co.uk> (raw)
In-Reply-To: <20260923084401.65336-1-ginger.jzllee@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Wed, Sep 23, 2026 at 04:44:01PM +0800, Ginger Li wrote:
> mchp_spdiftx_interrupt() is a hardirq handler and takes ctrl->lock to
> serialize the user data and channel status updates, while
> mchp_spdiftx_trigger() takes the same lock with spin_lock() from process
> context.
> Interrupts stay enabled while the lock is held in mchp_spdiftx_trigger(), so
> if an SPDIFTX interrupt is delivered on the CPU that is inside that critical
> section, the hardirq handler spins on a lock that the interrupted code is
> holding and can never release.
Are you sure, interrupts should be disabled during trigger...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-09-23 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:44 [PATCH] ASoC: mchp-spdiftx: Fix a deadlock with the interrupt handler Ginger Li
2026-09-23 13:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arPV9kcq3hEv4F1v@sirena.co.uk \
--to=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=ginger.jzllee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox