From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Brian Norris <briannorris@chromium.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, linux-iio@vger.kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
linux-kernel@vger.kernel.org,
"Fabrice Gasnier" <fabrice.gasnier@st.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] PM: runtime: Propagate last_busy from dependent to dependency
Date: Tue, 13 Oct 2026 09:11:08 +0300 [thread overview]
Message-ID: <as3LfIU9bi5GY2cm@ashevche-desk.local> (raw)
In-Reply-To: <as1qe_J37Njol797@google.com>
On Mon, Oct 12, 2026 at 04:17:15PM -0700, Brian Norris wrote:
> On Mon, Oct 12, 2026 at 10:58:24PM +0300, Andy Shevchenko wrote:
> > On Mon, Oct 05, 2026 at 11:05:28AM -0700, Brian Norris wrote:
> > > On Sat, Oct 03, 2026 at 06:21:44PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Oct 02, 2026 at 04:03:07PM -0700, Brian Norris wrote:
...
> > > > > Cc: Ulf Hansson <ulfh@kernel.org>
> > > >
> > > > Can go under the '---' cutter, so it won't pollute the commit message in the
> > > > Git history.
> > >
> > > This is a well-documented convention.
> > >
> > > Documentation/process/submitting-patches.rst
> > >
> > > If a person has had the opportunity to comment on a patch, but has not
> > > provided such comments, you may optionally add a ``Cc:`` tag to the patch.
> > > This tag documents that potentially interested parties have been included in
> > > the discussion.
> > >
> > > I'm directly referencing Ulf's suggestions (Link tag), so I'm also
> > > making it explicit that I'm CC'ing him.
> >
> > This piece of the documentation was written long time ago before we have got
> > the kernel.org controlled mailing archives (now it's lore.kernel.org). I argue
> > that this piece is outdated and we need to look at all aspects of the commit
> > message. Perhaps having one might not lead to the issue, but exempli gratia 20
> > is. I still think it should be moved to under '---' to show the good example.
>
> Well, it's not 20; it's 1, with a clear reason.
Yes, I aware of that — "having one might not lead to the issue".
> So not sure what you're saying. Anyway, I've prepped that for v2.
> Do you think you could propose a documentation update, if it's really so
> out-of-date with current practice?
I posted some a few months ago, when I pointed out to that noise in the commit
messages, it was like a pushback, but since that I have convinced several
developers to follow, so it might be worth to try again (but it should not be
insisting, just a recommendation). Also note, that even in the cited piece
there is no clear point where to put that Cc tag. It's only required for
stable backporting process to be in the commit message, otherwise that tag
may well be located after the '---' line which still makes it a (email)
tag, but visible in the commit message.
> FWIW, a quick look at the v7.1..v7.2 git log shows over 10,000 Cc lines
> that aren't for stable@ or similar, with over 900 different addressees,
> across roughly 1300 different commits. (For comparison, there are 17,833
> commits in v7.1..v7.2.)
Have you checked in dynamics? (Note, most of those Cc comes from Andrew
Morton's scripts and TIP tree.)
I used this:
$ git log --no-merges --grep '^Cc:' --pretty="%(trailers:key=Cc)" v<$A>..v<$B> | grep -v '^$' | grep -v 'stable@vger.kernel.org' | grep -v stable.*@kernel.org | wc -l
where <$A> and <$B> give a range.
v6.19..v7.0: 11525
v7.0..v7.1: 11594
v7.1..v7.2: 10946
v7.2..v7.3-rc7: 8696
You see, it works!
> It seems like you'll have a hard job trying to apply your rule to
> everybody's changes, especially if it conflicts with the documentation.
As I explained above it doesn't really conflict, it rather old established
process when people want to have that Cc be recorded, now we have
lore.kernel.org for that and I successfully convinced several people to follow.
> > > > > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > > > > ---
> > > >
> > > > Cc: ...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-13 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 23:03 [PATCH 0/5] PM: runtime: Improve autosuspend child to parent propagation Brian Norris
2026-10-02 23:03 ` [PATCH 1/5] PM: runtime: Only queue an idle check for RPM-linked suppliers (part 2) Brian Norris
2026-10-02 23:03 ` [PATCH 2/5] PM: runtime: Convert last_busy to atomic64_t Brian Norris
2026-10-02 23:03 ` [PATCH 3/5] PM: runtime: Propagate last_busy from dependent to dependency Brian Norris
2026-10-03 15:21 ` Andy Shevchenko
2026-10-05 18:05 ` Brian Norris
2026-10-12 19:58 ` Andy Shevchenko
2026-10-12 23:17 ` Brian Norris
2026-10-13 6:11 ` Andy Shevchenko [this message]
2026-10-02 23:03 ` [PATCH 4/5] PM: runtime: Add tests for last_busy propagation Brian Norris
2026-10-02 23:03 ` [PATCH 5/5] iio: adc: stm32-adc: Drop runtime_idle() Brian Norris
2026-10-06 12:42 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as3LfIU9bi5GY2cm@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@kernel.org \
--cc=briannorris@chromium.org \
--cc=dlechner@baylibre.com \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox